Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide IStateDB in retro #287

Merged
merged 1 commit into from Jul 22, 2021
Merged

Provide IStateDB in retro #287

merged 1 commit into from Jul 22, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jul 22, 2021

References

To address the jupyterlab-tour part of #286

Code changes

Add @jupyterlab/apputils-extension:settings to the retro app.

User-facing changes

Users should be able to take tours with RetroLab if the jupyterlab-tour extension is installed and tour exists.

Backwards-incompatible changes

None

@jtpio jtpio added the enhancement New feature or request label Jul 22, 2021
@jtpio
Copy link
Member Author

jtpio commented Jul 22, 2021

So this seems to fix it, although the existing tours are not usable:

image

@jtpio jtpio marked this pull request as ready for review July 22, 2021 18:48
@bollwyvl
Copy link
Collaborator

Notebook tour works like a frigging champ:

Screenshot from 2021-07-22 14-52-25

@jtpio
Copy link
Member Author

jtpio commented Jul 22, 2021

Notebook tour works like a frigging champ:

Ah right there is one for the notebook, great!

@bollwyvl
Copy link
Collaborator

bollwyvl commented Jul 22, 2021

Unfortunately, the notebook and main tours are bundled together as a single plugin 😿

Our boring custom tour uses jp-JupyterLogo to fire it up, so that could probably be fixed, e.g. #jp-JupyterLogo, #jp-RetroLogo... should only be one on the page at a time... though there's probably enough stuff that's different to warrant multiple ones, scoped to each app's folder

@jtpio jtpio added this to In progress in MVP via automation Jul 22, 2021
@jtpio
Copy link
Member Author

jtpio commented Jul 22, 2021

Unfortunately, the notebook and main tours are bundled together as a single plugin crying_cat_face

Sounds like we could split them into multiple plugins upstream? Which should make it easier to disable / enable here.

@jtpio
Copy link
Member Author

jtpio commented Jul 22, 2021

So this should then be good to go!

We can iterate on the tours separately.

@jtpio jtpio merged commit 943006b into jupyterlite:main Jul 22, 2021
MVP automation moved this from In progress to Done Jul 22, 2021
@jtpio jtpio deleted the istatedb-retro branch July 22, 2021 19:34
@jtpio
Copy link
Member Author

jtpio commented Jul 23, 2021

Sounds like we could split them into multiple plugins upstream?

Opened jupyterlab-contrib/jupyterlab-tour#40 to discuss.

@jtpio jtpio added this to the 0.1.0 milestone Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
MVP
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants