Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom About Dialog #60

Closed
jtpio opened this issue Apr 22, 2021 · 1 comment · Fixed by #140
Closed

Custom About Dialog #60

jtpio opened this issue Apr 22, 2021 · 1 comment · Fixed by #140
Projects

Comments

@jtpio
Copy link
Member

jtpio commented Apr 22, 2021

Problem

As more people get to try JupyterLite by going to the demo link directly: https://jupyterlite.vercel.app/

We should provide a way for them to reach the repo, for example by swapping the about dialog for a custom one:

image

Proposed Solution

The about plugin was made more modular upstream in jupyterlab/jupyterlab#10089.

So this will be easier to implement after updating to the 3.1 alpha packages.

@bollwyvl bollwyvl added this to To do in MVP May 22, 2021
@jtpio jtpio mentioned this issue Jun 3, 2021
4 tasks
@jtpio
Copy link
Member Author

jtpio commented Jun 3, 2021

The about dialog could also be the same for both lab and retro.

MVP automation moved this from To do to Done Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
MVP
Done
Development

Successfully merging a pull request may close this issue.

1 participant