Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the about help dialog to its own plugin #10089

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Move the about help dialog to its own plugin #10089

merged 2 commits into from
Apr 13, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 13, 2021

References

Follow-up to #10086:

  • Move the about dialog to its own plugin, so it can be disabled or replaced in downstream distributions
  • Rename @jupyterlab/help-extension:plugin to @jupyterlab/help-extension:resources

Code changes

Add a new @jupyterlab/help-extension:about plugin.

User-facing changes

None

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jtpio jtpio added this to the 3.1 milestone Apr 13, 2021
blink1073
blink1073 approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 84c7bae into jupyterlab:master Apr 13, 2021
@jtpio jtpio deleted the about-plugin branch April 13, 2021 15:49
@jtpio jtpio mentioned this pull request Apr 22, 2021
Closed
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Oct 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
maintenance pkg:help status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpio @blink1073