Adopt ruff, clean up linting
#1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jtpio
force-pushed
the
simplify-dev-setup
branch
from
fba4052
to
e4bdce1
Compare
|
Should be good to go for now, and can still be iterated on in follow-up PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Small step towards #684 focused on linting.
Align linting setup with upstreams.
Code changes
Try to progressively align the repo with other Jupyter projects to reduce friction and frustration when working on this repo:
ruffLINTING_IN_CIenv var and its dodo logicdodo.pyhuskyandlint-staged.User-facing changes
None for end users.
Backwards-incompatible changes
None