Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning in the Altair example #1181

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 29, 2023

References

As reported in #1141.

Code changes

Update the "Interactive Average" altair example: https://altair-viz.github.io/gallery/selection_layer_bar_month.html

User-facing changes

Executing the Altair example should not give a warning anymore:

image

Backwards-incompatible changes

None

@jtpio jtpio added the documentation Improvements or additions to documentation label Sep 29, 2023
@jtpio jtpio added this to the 0.1.x milestone Sep 29, 2023
@github-actions
Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

@jtpio jtpio modified the milestones: 0.1.x, 0.2.0 Sep 29, 2023
@jtpio jtpio mentioned this pull request Sep 29, 2023
14 tasks
Copy link
Collaborator

@bollwyvl bollwyvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing no particular errors related to altair in the exmaple notebook or js console

@jtpio jtpio merged commit f3ce47d into jupyterlite:main Sep 29, 2023
22 checks passed
@jtpio jtpio deleted the examples branch September 29, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants