Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extra console.log, avoid future console.log noise #1235

Merged
merged 2 commits into from Oct 28, 2023
Merged

Fix extra console.log, avoid future console.log noise #1235

merged 2 commits into from Oct 28, 2023

Conversation

bollwyvl
Copy link
Collaborator

References

Code changes

  • remove errant console.log
  • make future, unexpected console.(log|info) eslint errors
  • // eslint-disable-next-line no-console for existing, important things (redirecting working streams)

User-facing changes

  • users should not see debugging console noise when e.g. reporting errors

Backwards-incompatible changes

  • n/a

@github-actions
Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

@jtpio jtpio added this to the 0.2.x milestone Oct 27, 2023
@bollwyvl bollwyvl marked this pull request as ready for review October 27, 2023 18:18
@bollwyvl bollwyvl requested a review from jtpio October 27, 2023 18:18
jtpio
jtpio approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@jtpio jtpio merged commit 5a871c6 into jupyterlite:main Oct 28, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
0.2.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bollwyvl @jtpio