Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add index.html to serve message #260

Merged
merged 1 commit into from Jul 14, 2021
Merged

add index.html to serve message #260

merged 1 commit into from Jul 14, 2021

Conversation

bollwyvl
Copy link
Collaborator

References

Code changes

appends index.html to avoid redirect problems.

User-facing changes

  • jupyter lite serve will suggest a page that exists.

Backwards-incompatible changes

  • n/a

@bollwyvl
Copy link
Collaborator Author

Given the small scale of this, it's probably ready for review/merge.

jtpio
jtpio approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio added the documentation Improvements or additions to documentation label Jul 14, 2021
@jtpio jtpio added this to In progress in MVP via automation Jul 14, 2021
@jtpio jtpio merged commit 7e2648c into jupyterlite:main Jul 14, 2021
MVP automation moved this from In progress to Done Jul 14, 2021
This was referenced Jul 14, 2021
Closed
Closed
@jtpio jtpio added this to the 0.1.0 milestone Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
No open projects
MVP
Done
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bollwyvl @jtpio