Add RTC colors and usernames #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should also work in Retro: rtc-usernames-colors-retro.mp4 |
|
Opened jupyterlab/jupyterlab#10625 as we seem to be inheriting this issue as well (but not a blocker for this PR). |
|
looks good on RTD |
|
Nice, this is good to go then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Follow-up to #207
Similar to the implementation in JupyterLab:
Code changes
Handle username and colors in the custom RTC provider plugin.
User-facing changes
Nicer usernames and colors, that can also be set via query string parameters.
Backwards-incompatible changes
None