-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jupyter Releaser config #319
Conversation
cc @bollwyvl if you would like to have a first look, also if you have some input on the few changes to the If we are fine with having the top-level
Otherwise we could also format the changelog to convert to a PEP compliant version, and add more hooks and logic to push a custom tag. Probably implementing the custom get version option in the releaser would be better and easier long term anyway: jupyter-server/jupyter_releaser#150 |
Let's try it! |
So it looks like the Full Release workflow went through without hiccup for https://github.com/jtpio/jupyter_releaser/runs/3607208817?check_suite_focus=true https://github.com/jupyterlite/jupyterlite/releases/tag/v0.1.0a8 |
References
Fixes #121
Should also help address #7 (to check after a new release has been made with the releaser)
Code changes
Add configuration to make the repo compatible with https://github.com/jupyter-server/jupyter_releaser
TODO
py/jupyterlite
subfolder (not at the top-level)0.1.0a6
or0.1.0-alpha.6
?get_version
used by the releaser: https://github.com/jupyter-server/jupyter_releaser/blob/690b71130d99610f74c44f48746db9b21db57870/jupyter_releaser/util.py#L141-L148npm
version read from the top-levelpackage.json
since that is handled by the releaser out of the boxdodo.py
and remove thebuildutils
packageUser-facing changes
None
Backwards-incompatible changes
None