Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jupyter Releaser config #319

Merged
merged 41 commits into from
Sep 14, 2021
Merged

Add Jupyter Releaser config #319

merged 41 commits into from
Sep 14, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 7, 2021

References

Fixes #121

Should also help address #7 (to check after a new release has been made with the releaser)

Code changes

Add configuration to make the repo compatible with https://github.com/jupyter-server/jupyter_releaser

TODO

  • Release hooks and config
  • Make sure we can build the Python package in the py/jupyterlite subfolder (not at the top-level)
  • Upload distributions built by the release as artifacts for the check release workflow
  • Bump version script
  • Use version to use for the changelog and tag? 0.1.0a6 or 0.1.0-alpha.6?
  • Move integrity script to dodo.py and remove the buildutils package

User-facing changes

None

Backwards-incompatible changes

None

@jtpio
Copy link
Member Author

jtpio commented Sep 12, 2021

Looking good with the Python and npm packages being uploaded in dry run at the end of the check release check:

image

The dist archive also seem to contain all the files needed:

image

@jtpio
Copy link
Member Author

jtpio commented Sep 13, 2021

* Otherwise we can go with the `npm` version read from the top-level `package.json` since that is handled by the releaser out of the box

This is what it looks like in the check release:

Changelog

image

Tags

image

@jtpio
Copy link
Member Author

jtpio commented Sep 13, 2021

cc @bollwyvl if you would like to have a first look, also if you have some input on the few changes to the doit config.

If we are fine with having the top-level npm version used in the changelog and the GitHub tag (the next will be 0.1.0-alpha.7), we should be able to go ahead and merge this. Then I'll cut an automated release with the releaser and hopefully everything will go through 🤞

having the top-level npm version

Otherwise we could also format the changelog to convert to a PEP compliant version, and add more hooks and logic to push a custom tag. Probably implementing the custom get version option in the releaser would be better and easier long term anyway: jupyter-server/jupyter_releaser#150

@jtpio
Copy link
Member Author

jtpio commented Sep 14, 2021

If we are fine with having the top-level npm version used in the changelog and the GitHub tag (the next will be 0.1.0-alpha.7),

Looks like putting something in the form of 0.1.0a6 in the package.json version field is actually fine (this top-level package is private anyways):

image

@jtpio jtpio marked this pull request as ready for review September 14, 2021 14:29
@jtpio
Copy link
Member Author

jtpio commented Sep 14, 2021

Let's try it!

@jtpio jtpio merged commit b8f942b into jupyterlite:main Sep 14, 2021
@jtpio jtpio deleted the releaser branch September 14, 2021 15:41
@jtpio
Copy link
Member Author

jtpio commented Sep 15, 2021

So it looks like the Full Release workflow went through without hiccup for v0.1.0a8 🎉

https://github.com/jtpio/jupyter_releaser/runs/3607208817?check_suite_focus=true

https://github.com/jupyterlite/jupyterlite/releases/tag/v0.1.0a8

@jtpio jtpio added this to the 0.1.0 milestone Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release scripts
1 participant