-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation with Jupyterlite demo #8
Conversation
65d1b50
to
4dfbe58
Compare
4dfbe58
to
1e1d8c2
Compare
Looks ready, but to try it in the built documentation of the PR, the src path of the iframe must be change from To test the git puller feature, this link can be used https://litegitpuller--8.org.readthedocs.build/en/8/?repo=https%3A%2F%2Fgithub.com%2Fbrichet%2Ftesting-repo&urlpath=tree%2Ftesting-repo%2Fnotebooks%2Fsimple.ipynb&branch=main, but the first slash of the iframe src need to be removed in the html source. |
docs/Makefile
Outdated
@@ -0,0 +1,20 @@ | |||
# Minimal makefile for Sphinx documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally we should be able to avoid using a Makefile
, to make things simpler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example we could follow the voici
setup and use hatch scripts: https://github.com/voila-dashboards/voici/blob/1587e7bfa2a87b71be568a20e385dd9d8da6e2ae/pyproject.toml#L135-L140
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I updated the PR.
Can you explain when this additional hatch script for documentation is triggered ?
As far as I understand readthedoc build the documentation itself for PRs and branch.
@jtpio does the RTD preview action is usually working on voici https://github.com/voila-dashboards/voici/blob/1587e7bfa2a87b71be568a20e385dd9d8da6e2ae/.github/workflows/rtd-preview.yml ? |
Yes, for example: voila-dashboards/voici#89 (comment) But the workflow would first have to be merged and available on |
This is caused by jupyterlite/jupyterlite-sphinx#108. |
The badge is visible but it leads me to a 404. |
Fixed in jupyterlite-sphinx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We can double check the |
This adds a first documentation including a jupyterlite demo.
Wait for jupyterlite/jupyterlite-sphinx#108 to be merged.
Fixes #6