Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation with Jupyterlite demo #8

Merged
merged 10 commits into from
Sep 13, 2023
Merged

Add documentation with Jupyterlite demo #8

merged 10 commits into from
Sep 13, 2023

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Sep 7, 2023

This adds a first documentation including a jupyterlite demo.

Wait for jupyterlite/jupyterlite-sphinx#108 to be merged.

Fixes #6

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Binder 👈 Launch a Binder on branch jupyterlite/litegitpuller/readthedoc_example

@brichet brichet changed the title Add a first documentation Add documentation with Jupyterlite demo Sep 8, 2023
@brichet brichet marked this pull request as ready for review September 11, 2023 15:25
@brichet brichet requested a review from jtpio September 11, 2023 15:25
@brichet
Copy link
Collaborator Author

brichet commented Sep 11, 2023

Looks ready, but to try it in the built documentation of the PR, the src path of the iframe must be change from src=/lite/lab to src=lite/lab (removing the first slash).
I assume (and hope) it only occurs on the documentation generated for a PR.

To test the git puller feature, this link can be used https://litegitpuller--8.org.readthedocs.build/en/8/?repo=https%3A%2F%2Fgithub.com%2Fbrichet%2Ftesting-repo&urlpath=tree%2Ftesting-repo%2Fnotebooks%2Fsimple.ipynb&branch=main, but the first slash of the iframe src need to be removed in the html source.

docs/Makefile Outdated
@@ -0,0 +1,20 @@
# Minimal makefile for Sphinx documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally we should be able to avoid using a Makefile, to make things simpler.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I updated the PR.
Can you explain when this additional hatch script for documentation is triggered ?
As far as I understand readthedoc build the documentation itself for PRs and branch.

@brichet
Copy link
Collaborator Author

brichet commented Sep 12, 2023

@jtpio does the RTD preview action is usually working on voici https://github.com/voila-dashboards/voici/blob/1587e7bfa2a87b71be568a20e385dd9d8da6e2ae/.github/workflows/rtd-preview.yml ?
It does not work on the current opened PR, neither on some closed I tried.

@jtpio
Copy link
Member

jtpio commented Sep 12, 2023

Yes, for example: voila-dashboards/voici#89 (comment)

But the workflow would first have to be merged and available on main.

@brichet
Copy link
Collaborator Author

brichet commented Sep 12, 2023

the src path of the iframe must be change from src=/lite/lab to src=lite/lab (removing the first slash)

This is caused by jupyterlite/jupyterlite-sphinx#108.
I'll open a PR to fix it.

@brichet
Copy link
Collaborator Author

brichet commented Sep 12, 2023

Yes, for example: voila-dashboards/voici#89 (comment)

The badge is visible but it leads me to a 404.

@brichet
Copy link
Collaborator Author

brichet commented Sep 13, 2023

the src path of the iframe must be change from src=/lite/lab to src=lite/lab (removing the first slash)

This is caused by jupyterlite/jupyterlite-sphinx#108.
I'll open a PR to fix it.

Fixed in jupyterlite-sphinx

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio
Copy link
Member

jtpio commented Sep 13, 2023

We can double check the Check Links job passes correctly on CI once merged into main.

@jtpio jtpio merged commit 42fb51c into main Sep 13, 2023
5 of 6 checks passed
@jtpio jtpio deleted the readthedoc_example branch September 13, 2023 08:32
@brichet brichet added the documentation Improvements or additions to documentation label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JupyterLite demo on ReadTheDocs
2 participants