Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to a federated serverlite extension #1

Merged
merged 35 commits into from
Sep 30, 2021
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 29, 2021

Continue the switch to a federated serverlite extension:

TODO

  • Switch back to 0.1.0-alpha.x versioning
  • Add liteExtension key to the package.json to indicate this is not a regular lab extension
  • Fix CI
  • Fix releaser config
  • Add docs to the readme
  • Rename Python package to jupyterlite-p5-kernel?
  • Book name on PyPI: https://pypi.org/project/jupyterlite-p5-kernel/

@jtpio jtpio added the new label Sep 29, 2021
@bollwyvl
Copy link

Just thinking out loud: the happy path might be:

  • labextension build
    • puts stuff in p5_kernel/labextension
  • setup.py sdist bdist_wheel
    • puts stuff in $CRAZYTOWN/share/jupyter/labextensions
  • pip install jupyterlite-p5-kernel
    • puts stuff in $PREFIX/share/jupyter/labextensions
  • jupyter lite build
    • finds it
      • add to federated_extensions
      • looks in package.json
        • find it's a serverlite_extension
          • add to lite_extensions
  • at run-time
    • hand to the JupyterBackEndApplication
    • don't hand to the JupyterFrontentEndApplication

easy, right!?

return json.load(f)["version"]
version = json.load(f)["version"]
return (
version.replace("-alpha.", "a")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blearg, how many times have i written this 🤣

@bollwyvl
Copy link

import { JavaScriptKernel } from '@jupyterlite/javascript-kernel'

Should we also sharedPackage for @jupyterlite/javascript-kernel, at least for the time being?

@jtpio
Copy link
Member Author

jtpio commented Sep 29, 2021

Should we also sharedPackage for @jupyterlite/javascript-kernel, at least for the time being?

Yes sounds good 👍 At least if we continue shipping it by default. Otherwise it would be using its own copy of @jupyterlite/javascript-kernel which should also be fine for now.

@jtpio
Copy link
Member Author

jtpio commented Sep 29, 2021

Just thinking out loud: the happy path might be:

Yes, which should almost correspond to the current state of jupyterlite/jupyterlite#352.

I'll finish this PR and cut a first release of p5-kernel-lite to PyPI so we can test on jupyterlite/jupyterlite#352

For the name of the federated kernel, we could go for:

  • jupyterlite-p5-kernel
  • p5-kernel-lite

The second sounds good, but would be fine with the first one too. Later we can imagine having xeus-lua-lite which might look better than jupyterlite-xeus-lua.

@jtpio
Copy link
Member Author

jtpio commented Sep 29, 2021

The second sounds good, but would be fine with the first one too

jupyterlite-p5-kernel is actually similar to what many lab extensions have been using (jupyterlab-myextension). So going with that name would also be fine.

@jtpio jtpio marked this pull request as ready for review September 30, 2021 07:17
@jtpio
Copy link
Member Author

jtpio commented Sep 30, 2021

Should be good to go for a first iteration. We can iterate in follow-up PRs.

@jtpio jtpio merged commit b91d19f into main Sep 30, 2021
@jtpio jtpio deleted the federated-server-extension branch September 30, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants