Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle updating display data #11

Merged
merged 8 commits into from
Jan 20, 2023
Merged

Handle updating display data #11

merged 8 commits into from
Jan 20, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 16, 2021

Depends on jupyterlite/jupyterlite#394

So updating variables in different code cells feels more natural and updates existing sketches in real time.

p5-update-display.mp4

@jtpio
Copy link
Member Author

jtpio commented Jan 19, 2023

Also needs some changes now that jupyterlite/jupyterlite#711 is released.

@jtpio
Copy link
Member Author

jtpio commented Jan 20, 2023

Switching back to using an IFrame since p5 depends quite a bit on window and document.

Looking good after the latest updates:

p5-display.mp4

@jtpio
Copy link
Member Author

jtpio commented Jan 20, 2023

Will be doing more updates in follow-up PRs.

@jtpio jtpio marked this pull request as ready for review January 20, 2023 14:46
@jtpio jtpio merged commit 9205846 into jupyterlite:main Jan 20, 2023
@jtpio jtpio deleted the updates branch January 20, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant