Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed readme #7

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

DerThorsten
Copy link
Contributor

The dev install instuctions are incomplete. It misses pip install jupyterite.
I also added cnda command to create a fresh env

README.md Outdated
# Install JupyterLab
python -m pip install jupyterlab
# create a new enviroment
conda create --name p5-kernel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we can also advertise mamba :)

Suggested change
conda create --name p5-kernel
mamba create --name jupyterlite-p5-kernel -c conda-forge python=3.9 yarn jupyterlab

README.md Outdated
# build a new JupyterLite site
jupyter lite build

# server the site
jupyter lite serve
jupyter lite serveatus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jop....this typo sneaked in

using mamba
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 35ebc2e into jupyterlite:main Oct 1, 2021
@jtpio jtpio added the documentation Improvements or additions to documentation label Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants