Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to jupyterlite-core==0.1.0b22 #34

Closed
wants to merge 4 commits into from
Closed

Update to jupyterlite-core==0.1.0b22 #34

wants to merge 4 commits into from

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 22, 2023 •
edited

Update to the latest release: https://github.com/jupyterlite/jupyterlite/releases/tag/v0.1.0b20

  • Update to jupyterlite-core==0.1.0b22
  • Disabling @jupyterlite/javascript-kernel-extension is not needed anymore

@github-actions
Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

bollwyvl
bollwyvl reviewed Mar 22, 2023
View reviewed changes
examples/jupyter-lite.json
@@ -1,9 +1,6 @@
{
"jupyter-lite-schema-version": 0,
"jupyter-config-data": {
"appName": "JupyterLite Pyodide Kernel",
"disabledExtensions": {
"@jupyterlite/javascript-kernel-extension": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

bollwyvl
bollwyvl approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@bollwyvl bollwyvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the right play, and will help make this repo's demo/test surface area smaller.

@jtpio
Copy link
Member Author

jtpio commented Mar 23, 2023

Restarted a check on main to double check and the test failure also happens there: https://github.com/jupyterlite/pyodide-kernel/actions/runs/4424765573/jobs/7914666020

@jtpio
Copy link
Member Author

jtpio commented Mar 23, 2023 •
edited

ah looks like it might be because jupyterlite-core==0.1.0b20 does not include the following two fixtures:

  • the-smallest-extension-0.1.0-py_0.tar.bz2
  • the_smallest_extension-0.1.0-py3-none-any.whl

I guess we could add them back upstream in jupyterlite-core although the upstream tests don't need them to pass apparently.

@jtpio
Copy link
Member Author

jtpio commented Mar 23, 2023

Looks like the tests in this repo should actually make use of the fixture available in https://github.com/jupyterlite/pyodide-kernel/blob/main/jupyterlite_pyodide_kernel/tests/fixtures/the_smallest_extension-0.1.0-py3-none-any.whl

@jtpio jtpio changed the title Update to jupyterlite-core==0.1.0b20 Update to jupyterlite-core==0.1.0b22 Mar 30, 2023
@bollwyvl bollwyvl mentioned this pull request Mar 31, 2023
Merged
8 tasks
@jtpio
Copy link
Member Author

jtpio commented Mar 31, 2023

Fixed by #39

@jtpio jtpio closed this Mar 31, 2023
@jtpio jtpio deleted the update-lite-core branch March 31, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bollwyvl bollwyvl bollwyvl approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtpio @bollwyvl