Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Adopt ruff, black, fix various issues #169

Merged
merged 11 commits into from Oct 10, 2023
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 5, 2023

Build on top of #168

This will help catch potential issues:

  • Adopt ruff
  • Adopt black
  • Lint pass
  • Fix some typing issues
  • Run linting on CI

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

lite-badge 👈 Try it on ReadTheDocs

@jtpio jtpio changed the title Adopt ruff, fix various issues Adopt ruff, black, fix various issues Oct 5, 2023
@jtpio
Copy link
Member Author

jtpio commented Oct 5, 2023

Will wait for #168 to get in first.

@martinRenou
Copy link
Member

@jtpio FYI I'm rebasing this

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's merge when green

@martinRenou martinRenou marked this pull request as ready for review October 10, 2023 13:41
@martinRenou martinRenou merged commit cbcb474 into jupyterlite:main Oct 10, 2023
8 checks passed
@jtpio jtpio deleted the ruff branch October 10, 2023 13:50
@martinRenou
Copy link
Member

meeseeksdev backport to 0.x

meeseeksmachine pushed a commit to meeseeksmachine/xeus-python-kernel that referenced this pull request Dec 5, 2023
martinRenou added a commit that referenced this pull request Dec 5, 2023
* Backport PR #169: Adopt `ruff`, `black`, fix various issues

* Black

* Black again?

* Are you serious black

* Are you Sirius Black

---------

Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants