Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Fix conflicts with sys prefix packages and ignore ignore_sys_prefix flag #23

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Fix conflicts with sys prefix packages and ignore ignore_sys_prefix flag #23

merged 1 commit into from
Jun 17, 2022

Conversation

martinRenou
Copy link
Member

Fix #22

  • Fix incompatibility issue when there is a common labextension between the user prefix and the xeus-python-env prefix (e.g. ipyleaflet is installed in both), starting with this PR the labextension from xeus-python-env takes priority.
  • Always install the jupyterlite-xeus-python extension even if ignore_sys_prefix is enabled.

@martinRenou martinRenou added the enhancement New feature or request label Jun 13, 2022
@martinRenou
Copy link
Member Author

@benbovy please tell me what you think of this approach

@martinRenou martinRenou marked this pull request as ready for review June 13, 2022 09:35
@benbovy
Copy link
Contributor

benbovy commented Jun 14, 2022

I haven't tested it yet but the approach / logic seems right to me.

@martinRenou
Copy link
Member Author

Thanks for looking into it :) I'm merging for now and we can iterate more later.

@martinRenou martinRenou merged commit 7b7f048 into jupyterlite:main Jun 17, 2022
@martinRenou martinRenou deleted the fix_conflicts_sys_prefix branch June 17, 2022 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compatibility with "ignore_sys_prefix"
2 participants
@martinRenou @benbovy