Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Add support for environment.yml file #96

Merged
merged 11 commits into from Dec 22, 2022

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Dec 21, 2022

Fix #53

  • Add tests (Run the tests from the test directory and put an environment.yml file there)
  • Make the "environment.yml" file name configurable
  • Update docs
  • Update README

@martinRenou martinRenou marked this pull request as ready for review December 22, 2022 08:56
@martinRenou martinRenou merged commit 78fbd57 into jupyterlite:main Dec 22, 2022
@martinRenou martinRenou deleted the environment branch December 22, 2022 08:57
@nthiery
Copy link

nthiery commented Dec 22, 2022

Nice! I did not expect it to come so soon; thank you @martinRenou. Eager to try it.

Do you have some tentative timeline for when pip support might be added?

@martinRenou
Copy link
Member Author

martinRenou commented Dec 22, 2022

Do you have some tentative timeline for when pip support might be added?

Probably pure Python packages could simply be installed with pip and it might just be a matter of removing the check I added here and find the proper way to pass them to micromamba/mamba/conda. I would need to give it a try :)

I don't see any reason for pure Python packages to not work if installed with pip, I added the check because I'm not sure how to handle the non-pure packages, how to track them and show a nice error message at build time. Maybe we could just let it fail at runtime, though it would probably prevent the kernel to start without any feedback to the user.

@nthiery
Copy link

nthiery commented Dec 22, 2022

Thanks for the quick feedback! My use cases are plain Python indeed.
I'll experiment with it in January by removing the check in the source
(or even simpler if there can be an enable-pip experimental option?).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for installing packages from environment.yml files
2 participants