Typescript support #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thanks for the contribution. I'll get this released to npm soon. |
|
I just bumped into this. Proof that it's useful! Thanks for adding types @nickbreaton! I'm copying the |
|
Released as v0.2.4 Let me know if you have any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I noticed there was not a definition on DefinitelyTyped for this package. I thought maybe we could add it directly to this package? I tried to follow the same conventions you used throughout the code and build process.
If this isn't something you are interested in adding, I will just make the PR to DefinitlyTyped instead. However, this method prevents the user from having to manually add another dependency:
npm i -D @types/react-display-nameThanks!