Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot play any movies from TMDB helper widgets #332

Closed
AakashC2020 opened this issue Nov 1, 2020 · 13 comments
Closed

Cannot play any movies from TMDB helper widgets #332

AakashC2020 opened this issue Nov 1, 2020 · 13 comments

Comments

@AakashC2020
Copy link

Hi jurialmunkey,

I cannot play any movies from TMDB helper widgets video info page or context menu. For local files or web files, where I chose "Seren (Source Select)" player, if I click on play, it's opening the context menu. After that if I click on Play again on the context menu it's simply crashing Kodi. I tried changing resolve_url settings for the player as well but the issue is still happening.

After changing resolve_url settings for the player, web files can be played from within the TMDB helper addon (not through widgets) via the context menu but not from within the video info page (which still crashes Kodi). For local files a pop up is showing up to "Play Media" or "Resolve URL". If I click on "Play Media" my local video is being played. Clicking on "Resolve URL" option also plays the local file but without my default player settings. However, if I want to play the local movie via "Seren (Source Select)" player and choose "Select player" option then the same context menu pops up but no player selection option is there.

Please advise. Thanks!

@jurialmunkey
Copy link
Owner

What skin is this happening in? Also can you get me a debug log of the crash?

@AakashC2020
Copy link
Author

AakashC2020 commented Nov 1, 2020

Hi jurialmunkey,
The above issue is happening on the Arctic Zephyr 2 skin.
Here is the debug log of the crash:

EDIT by jurialmunkey - I moved your log into a paste to make it more readable
https://paste.kodi.tv/utihodocil.kodi

@AakashC2020
Copy link
Author

AakashC2020 commented Nov 1, 2020

Please note that this Kodi crashing issue was not there in version 3.x series of the TMDB Helper. Also, as I mentioned above that "Select Player" option is no longer working. It just opens the context menu.

People have written about this issue on Reddit as well. See here:
https://www.reddit.com/r/Addons4Kodi/comments/ji7ms3/tmdb_helper_widgets_crash_kodi/?utm_medium=android_app&utm_source=share

@jurialmunkey
Copy link
Owner

What do you mean by "context menu"? Can you get me a screen shot?

Also I don't see anything related to TMDbHelper in that log. All I see is another addon (Seren) throwing an error exception - I can't control errors in other plugins.

@AakashC2020
Copy link
Author

Hi jurialmunkey,
I guess the issue is not with the Seren addon. Something happened between the TMDB Helper players and the addon. Seren is running fine on my Kodi setup. Let me explain you the current scenario. I've created a widget for "Movies Trending Today" on Kodi with Arctic Zephyr 2 Skin. I've also set resolve_url as true for Seren (Source Select) player. Now when I'm opening a particular non-local movie's video info page from the widget and clicking on the play button, then instead of playing the video it is opening the context menu with various options like play, etc. Now when I'm clicking on play from the context menu again then Kodi is immediately crashing. For local movies from the same widget, if I click on the play button then nothing is happening, no video is played. It simply returns to Kodi's home page. However if I click play from the context menu of the same widget for local movies as well then Kodi is crashing immediately. Also, as I said earlier that if I click on the "Select Player" option from the context menu then no player selection page pops up, instead the same context menu opens again. Please note that all these issues are happening mainly from the widget page so I guess there is something wrong with the addon and its widget settings.

Also, I shared the below link from reddit where other people are facing issues similar to mine. This might help you understand the problem as well.
https://www.reddit.com/r/Addons4Kodi/comments/ji7ms3/tmdb_helper_widgets_crash_kodi/?utm_medium=android_app&utm_source=share

Could you kindly try to replicate the problem from your end and see what is the cause of the issue? Please note that version 3.x of this addon is still running fine. There are no crashes on that one. Thanks!

@AakashC2020
Copy link
Author

Hi jurialmunkey,
Apologies, kindly ignore my above comment. There was some issue with one of my Kodi setup. Now I've fixed that by restoring a previous version. The Kodi crashing issue is fixed. However, there is a new issue now. If I try to play any local movie from the TMDB Helper widget by going inside the video info page and clicking play then nothing happens. It just returns to the home page of Kodi. Then if I click play from the context menu I see the below pop up message:

IMG_20201102_113924

If I choose Play Media the video plays fine. However, why does this pop up appear for the local video files? How can I set resolve_url settings for my default Kodi player? There is no option for that in the Tmdb helper addon. Also, why does the local video file does not play from the video info page, whereas all non-local files are playing fine via the video info page. Please advise. Thanks!

@AakashC2020
Copy link
Author

AakashC2020 commented Nov 2, 2020

Hi jurialmunkey, I think I found the issue. It can be isolated to 2 things. As soon as I changed the default select option in the Tmdb helper settings to "Browse" (from "Play") and then I clicked on the "Refresh Details" context menu item the same issue of Kodi crashing started happening again. I guess there is some problem with either the "Browse" option or the "Refresh Details" option. They are changing something in the addon permanently and causing the crashing issue. Please advise. Thanks!

P. S. I thoroughly checked on my various devices and it's definitely either of these 2 options that's causing the Kodi crashing issue. However, I couldn't isolate which one of these 2 is causing the issue.

Also, please try to fix the other issue for which I shared the screenshot in my above comment.

@jurialmunkey
Copy link
Owner

jurialmunkey commented Nov 2, 2020

Ah I just completely forgot about the local file player when I added the setResolvedURL code in. That should be fixed on latest.

The Browse option is only a recent addition - I hadn't actually planned on carrying the browse approach over from v3 since you can also access the same menu via the "Browse lists" option in the context menu, so it hasn't been tested all that much.

I'll have a look into it - definitely wouldn't be surprising that it is causing issues with playback since it modifies what the end folder path is from being the play callback URL to the browse one. Thanks for your detective work!

Also what version are you currently using? There was an issue where Kodi was wiping the path for the item in the info dialog if you also had the item in the library - but I'm pretty sure I fixed that last night.

@AakashC2020
Copy link
Author

AakashC2020 commented Nov 2, 2020

Hi jurialmunkey,

You're welcome! Glad to help you!

I'm using Kodi version 18.9, tmdb helper version 4.0.28 and tmdb helper context menu version 1.0.2

So, I hope I can use "Refresh Details" option if you think that is not causing the crashing issue?

Please let me know when the resolve_url issue is fixed for local content so that I can download the updated version from GitHub. Hope I'll be able to play the local files from within the video info page after that instead of using the context menu everytime?

Also, kindly let me know if the "Browse" option gets fixed.

Thank you!

P. S. I checked again on various devices and found out that the crashing issue is not caused by "Refresh Details" option. Therefore, I can conclude that it's definitely the "Browse" option that's causing the crashing issue.

@AakashC2020
Copy link
Author

Hi jurialmunkey,

Further to my comment above, I updated the TMDB Helper addon to version 4.0.33 from your GitHub master file.
Now, both local and non-local videos are playing fine.
Thanks!

@jurialmunkey
Copy link
Owner

^^^ That commit should fix the browse issue, which I believe is the last issue remaining in this thread so closing it as resolved.

I'm not quite sure why the way I had it was causing a crash in this particular scenario but using RunPlugin as an alternative approach appears to work.

@AakashC2020
Copy link
Author

Hi jurialmunkey,
Thank you! I'll check later on if everything works fine.

@AakashC2020
Copy link
Author

Hi jurialmunkey,
I checked everything related to this issue and can confirm that the browse issue is fixed now. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants