-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No fallbak to English artwork #654
Comments
And Im with a raspberry pi4 with libreelec, version 10.0.1. |
^^^ Can you try v4.6.6? I think that should work. You'll need to refresh the artwork for the item from the context menu |
for example, for the new chainsaw massacre, I don't have a clearlogo, yet I checked "return to English when the main language is not available |
@shkope |
ok but when I put language US I have the chainsaw massacre clearlogo |
Yes ilt's better with the new version, 4.6.6, but the point is when you check all the cases with Fan art from the tmdb settings, the french version does not exist in the fanart website but it does with TMDB, cos I can choose it from the context menu and manage artwork, (for example with the eternals, the matrix ressurections, hotel transylvania). |
For ''The chainsaw massacre'' example, the clearlogo comes from TMDb not from Fanart,tv.. For the new Texas Chainsaw Massacre:
|
I am now testing in French. I got all the artworks you listed without any problems in French. Delete cache and reset kodi. |
@Guillaume5464 - Latest version gives an option in the fanart.tv settings that will check TMDb for artwork first Preference becomes: Remember you can also use the manage artwork dialog to set artwork manually if necessary. As long as you don't delete your item details cache, manually set artwork is stored forever.
@alKODIque - Latest version will also apply the fallback language option to TMDb as long as you don't enable the prefer artwork from TMDb first option. FanartTV first + Fallback = FanartTV second + Fallback = There's no option for checking both for language first and then both for a fallback because that will impact performance (needs a second pass). That's why enabling TMDb to be first disables the fallback for it.
@matke-84 - only Fanart.tv was setup to use fallback language. TMDb was set pull language only. Latest version changes that. |
@jurialmunkey |
@jurialmunkey |
@jurialmunkey I did like you said and set FRench as main language then: It's now working! 🎉 Same thing with the new''Texas Chainsaw massacre'' 😉 Again, thanks for all the changes you made, I realy appreciate your work |
@alKODIque @jurialmunkey |
The Item Details cache for the item builder only stores the "best" artwork of each type for each API. Changing the fallback setting potentially changes the "best" artwork available, so you need to refresh the item cache for the item to force a rebuild. FYI - No need to delete FanartTV or TMDb caches as these store the entire request. It is only the item details that need to be refreshed to force a rebuild. Also, it is only fallback settings that require a refresh. With the way the cache is structured and how the process works, quality changes or prefer TMDb first are able to be applied immediately:
The "Prefer artwork from TMDb first if available" option just switches steps 3/4 so that FanartTV is added to the listitem first and then TMDb overwrites rather than the other way around -- that's why it doesn't need a refresh but fallback change does. |
@jurialmunkey |
If main language is French, the following options give: "Prefer TMDb" + "English Fallback" "English Fallback" + NOT "Prefer TMDb" "Prefer TMDb" + NOT "English Fallback" NOT "Prefer TMDb" + NOT "English Fallback" |
Ok, so it should show fallback clearlogo in English, which is not case at the moment for some movies (Marry me, Kimi, Texas chainsaw massacre, Ted K...). This should be fixed then. And please, if at possible, do this.
|
No because Texas Chainsaw Massacre does not have a clearlogo on Fanart TV Neither does Ted K "Prefer TMDb" + "English Fallback" does NOT get English fallback art from TMDb. It ONLY gets Language or None. |
@jurialmunkey |
Hey hey, ah yes its much better, thanks a lot 😀, and i've got another issue but its about the title's label, when i change it, it takes my changes but keep the one written in the tmdb, for exemple the title of my widget is : "films populaires(my changes) popular films(tmdb)" |
@Guillaume5464 |
@matke-84 Ok but the only option I found is to enable clearlogos on widgets but whatever I do with it, checked or not checked there are still those "titles" at the bottom right corner. |
@Guillaume5464 |
@Guillaume5464 - matke-84 is correct, those are skin matters (widget label and overlaying logo). TMDbH just supplies the data. How it is displayed is up to the skin. I think this issue with fallback is resolved now, so I will close it. |
Hi,
I am on kodi 19.3 matrix with auramod and tmdb helper, version 4.6.5, the last one I guess and using it in french version, but the fallback to english artwork its not working, actually its taking the first one on the list, when I go to change the landscape, so sometimes its in russia, or deutch... And for some landscape, the french version exits but it dosent take it.
Hope I was clear enough ;-)
Thanks for your help.
The text was updated successfully, but these errors were encountered: