Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Head tail #55

Merged
merged 26 commits into from Sep 22, 2020
Merged

Head tail #55

merged 26 commits into from Sep 22, 2020

Conversation

alexgarel
Copy link
Member

See CHANGELOG for changes !

Also I moved tests to their own folder because of problems with coveralls (and it's better like that)

@alexgarel
python 3.8 support (and dropped 3.4 and 3.5)
2b2b9fe
@alexgarel
basic support for head, tail, position
2bd37b1
@alexgarel
better error handling
265d2cb
@alexgarel
skip ES test if no elasticsearch instance
ac4fc1f
@alexgarel
trivial fix for constistency
426f5aa
@alexgarel
flake8 now include parser.py
9963a8f
@alexgarel
fix token definition order to avoid uncompatible change
2c5d6bc
@alexgarel
small fix in documentation
2bab4b1
@alexgarel
small fix in ES connection handling in test
f42d810
@alexgarel
head and tail used in printing
3626d6a
@alexgarel
add span method to tree elements
2e361f6
@alexgarel
flake8 fixes
9614cf9
@alexgarel
bug fix on Range equality
7451852
@alexgarel
Boost equality should check force + better printing of Proximity and …
658571c 
…Fuzzy items
@alexgarel
added a clone_item and set children feature
9fb7c2e
@alexgarel
new visitor and transformer pattern
1a7ab82
@alexgarel
add branch coverage
f591ff4
@alexgarel
Added support for size of element in original expression
9b19701
@alexgarel
travis: target coveralls only on one tests
a743fab
@alexgarel
small improvement to visitor and clone
bf9167a
@alexgarel
moving tests to a top directory to avoid coveralls including tests
9e890a4
@alexgarel
fix small bug on NOT __str__
ac6229a
@coveralls
Copy link

coveralls commented Sep 1, 2020 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 65ed443 on head-tail into 5373e44 on master.

@yolocodefrench
Copy link
Contributor

yolocodefrench commented Sep 2, 2020 •
edited

Review :

  • In quick start in the documentation, the LuceneTreeParser is used. the problem is that it's deprecated now
  • The API section of the documentation is not up to date

yolocodefrench
yolocodefrench reviewed Sep 4, 2020
View reviewed changes
Copy link
Contributor

@yolocodefrench yolocodefrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated a bit the documentation to keep it up to date with the TreeTransformer

@alexgarel alexgarel merged commit ba617c8 into master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yolocodefrench yolocodefrench yolocodefrench left review comments

@roxanebellot roxanebellot roxanebellot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexgarel @coveralls @yolocodefrench @roxanebellot