fixing comments for 2010 starter edition

jurriaan · Jan 23, 2014 · 19dd9ed · 19dd9ed
1 parent 89a39ae
commit 19dd9ed
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/lib/axlsx/workbook/worksheet/comments.rb b/lib/axlsx/workbook/worksheet/comments.rb
@@ -57,8 +57,7 @@ def authors
     # @return [Array]
     def relationships
       [Relationship.new(self, VML_DRAWING_R, "../#{vml_drawing.pn}"),
-       Relationship.new(self, COMMENT_R, "../#{pn}"),
-       Relationship.new(self, COMMENT_R_NULL, "NULL")]
+       Relationship.new(self, COMMENT_R, "../#{pn}")]
     end
 
     # serialize the object

diff --git a/test/workbook/worksheet/tc_worksheet.rb b/test/workbook/worksheet/tc_worksheet.rb
@@ -434,11 +434,11 @@ def test_relationships
     c = @ws.add_chart Axlsx::Pie3DChart
     assert_equal(@ws.relationships.size, 1, "multiple charts still only result in one relationship")
     c = @ws.add_comment :text => 'builder', :author => 'bob', :ref => @ws.rows.last.cells.last
-    assert_equal(@ws.relationships.size, 4, "adding a comment adds 3 relationships")
+    assert_equal(@ws.relationships.size, 3, "adding a comment adds 2 relationships")
     c = @ws.add_comment :text => 'not that is a comment!', :author => 'travis', :ref => "A1"
-    assert_equal(@ws.relationships.size, 4, "adding multiple comments in the same worksheet should not add any additional comment relationships")
+    assert_equal(@ws.relationships.size, 3, "adding multiple comments in the same worksheet should not add any additional comment relationships")
     c = @ws.add_pivot_table 'G5:G6', 'A1:D10'
-    assert_equal(@ws.relationships.size, 5, "adding a pivot table adds 1 relationship")
+    assert_equal(@ws.relationships.size, 4, "adding a pivot table adds 1 relationship")
   end