Replace cartopy dependency with own downloader. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
There is an incompatibility between `python<3.8` and `importlib_metadata==5.0.0` and (pydata/xarray#7115, NEP 29).
juseg
added a commit
that referenced
this pull request
Nov 18, 2022
* Remove cartopy dependency in doc, whatsnew. * Remove dependency on Cartopy. * Remove outdated cities plot methods. * Pylint had a lot of complaints on my code. * Add missing downloader dosctrings, homogenize. * Use new logic in NaturalEarthDownloader, it works! * Separate args, kwargs in generic Downloader call. * Add generic ArchiveDownloader base class. * Rewrite, document OSFDownloader. * Add CacheDownloader to download files in cache. * Split downloader call into url, path, check, get. * Require shapefile dbf, prj, shp, shx, ignore cpg. * Remove now-unused BasenameDownloader. * Fix plotting ehl11 paleoglaciers, crs is in .prj. * Store Natural Earth shapefiles in subdirectories. * Use XDG_CACHE_HOME env variable if present. * Add quick and dirty natural earth downloader. * Add commend with overnight ideas for subclassing. * Move hyoga.core.download to hyoga.open.downloader. * Fix download module header and docstring. * Add ZipShapeDownloader for Ehlers et al data. * Add tiny OSFDownloader class. * Remove _download_example private method. * Separate generic and basename downloaders. * Replace _download method with a downloader class. * Move download code to hyoga.core.download. Note: this will be force-pushed overriding the merge-commit b9b510e. For two hours yesterday GitHub's main pointed to that commit, but I meant to do a `merge --squash` not a real `merge`. Sorry if anyone checked out that merge commit.
juseg
added a commit
that referenced
this pull request
Nov 18, 2022
Without cartopy dependency docs can be built in virtualenv with pip. The readthedocs builds revealed an incompatibility between `python<3.8` and `importlib_metadata==5.0.0` (see pydata/xarray#7115, NEP 29). * Remove readthedocs conda enviromnent. * Ask readthedocs to use Python 3.8. * Require Python >= 3.8. * Remove readthedocs build settings. * Replace conda with pip for readthedocs build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #25.