Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround scipy 1.10.0 issue 17718. #59

Merged
merged 3 commits into from Jan 11, 2023
Merged

Workaround scipy 1.10.0 issue 17718. #59

merged 3 commits into from Jan 11, 2023

Conversation

juseg
Copy link
Owner

@juseg juseg commented Jan 11, 2023

Convert all data to float64 during profile interpolation if scipy==1.10.0 is in use. This could significantly affect memory load on large arrays. Behavior remains unchanged on other scipy versions, and interpolated data is always returned in original precision. This PR assumes the bug will be fixed in scipy>0.10.0. See scipy/scipy#17718. Close #58.

@juseg juseg added the bug Something isn't working label Jan 11, 2023
@juseg juseg added this to the v0.3.0 milestone Jan 11, 2023
@juseg juseg self-assigned this Jan 11, 2023
@juseg juseg linked an issue Jan 11, 2023 that may be closed by this pull request
@juseg juseg marked this pull request as ready for review January 11, 2023 12:47
@juseg juseg merged commit 10d622b into main Jan 11, 2023
@juseg juseg deleted the interp-precision branch March 7, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile interpolation crashes on scipy 1.10.0.
1 participant