feat(paymentmethods): boleto Payment Method Integration #195
Conversation
vsrivatsa-juspay
requested review from
prafulkoppalkar,
akash-c-k and
ArushKapoorJuspay
as code owners
Co-authored-by: ArushKapoorJuspay <121166031+ArushKapoorJuspay@users.noreply.github.com>
src/Payments/Boleto.res
Outdated
| None | ||
| }, [complete]) | ||
|
|
||
| let submitCallback = React.useCallback((ev: Window.event) => { |
There was a problem hiding this comment.
could you please add socialSecurityNumber as a dependency for useCallback
| let socialSecurityNumberBlur = ev => { | ||
| let val = ReactEvent.Focus.target(ev)["value"]->cleanSocialSecurityNumber | ||
| if val->Js.String2.length != 11 && val->Js.String2.length > 0 { | ||
| setSocialSecurityNumberError(_ => "The social security number entered is invalid.") |
There was a problem hiding this comment.
Please add this to LocaleString
There was a problem hiding this comment.
Would like to take this separately as refactoring. Same needs to be done in other input field errors such as blik code, sort code etc
| <div className="flex flex-col h-full justify-between items-center"> | ||
| <div className=" flex flex-col max-w-md justify-between items-center"> | ||
| <div className="flex flex-row w-full"> | ||
| <p className="Disclaimer font-medium text-sm text-[#151A1F] opacity-70"> |
There was a problem hiding this comment.
Is this className Disclaimer being used?
There was a problem hiding this comment.
This class was present in the qr modal as well, just reused it
| <button | ||
| className="w-full mt-6 p-2 h-[40px]" | ||
| style={ReactDOMStyle.make( | ||
| ~background="#006DF9", |
There was a problem hiding this comment.
@prafulkoppalkar should we use theme for these background and color?
There was a problem hiding this comment.
I personally don't think so. These are fullscreen modals not using theme-based/merchant custom styling
There was a problem hiding this comment.
but these are themeVariables right ..popups will look out of sync with rest of the SDK
…witch-web into feat/boleto_payment_method
# [0.27.0](v0.26.4...v0.27.0) (2024-03-05) ### Features * **paymentmethods:** boleto Payment Method Integration ([#195](#195)) ([f4fc04d](f4fc04d))
| @@ -284,6 +284,40 @@ let intentCall = ( | |||
| ("iframeId", iframeId->Js.Json.string), | |||
| ("metadata", metaData->Js.Json.object_), | |||
| ]) | |||
| } else if intent.nextAction.type_ === "display_voucher_information" { | |||
| let voucherData = intent.nextAction.voucher_details->Belt.Option.getWithDefault({ | |||
There was a problem hiding this comment.
| let voucherData = intent.nextAction.voucher_details->Belt.Option.getWithDefault({ | |
| let voucherData = intent.nextAction.voucher_details->Belt.Option.getWithDefault(getVoucherDetails(Js.Json.null)) |
# [0.27.0](juspay/hyperswitch-web@v0.26.4...v0.27.0) (2024-03-05) ### Features * **paymentmethods:** boleto Payment Method Integration ([#195](juspay/hyperswitch-web#195)) ([f4fc04d](juspay/hyperswitch-web@f4fc04d))
No description provided.