Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: saved Payment Method stuck in loading state and Card Holder Name for every saved card #241

Merged
merged 1 commit into from
Mar 20, 2024
Merged

fix: saved Payment Method stuck in loading state and Card Holder Name for every saved card #241

merged 1 commit into from
Mar 20, 2024

Conversation

ArushKapoorJuspay
Copy link
Contributor

Description

  1. SDK getting stuck on Saved Payment Method screen when no customer was provided
  2. Card Holder Name field was being asked by Dynamic Fields even when card holder name was present for that specific saved card

akash-c-k
akash-c-k previously approved these changes Mar 19, 2024
View reviewed changes
@akash-c-k akash-c-k merged commit 6b1bc56 into main Mar 20, 2024
3 checks passed
@akash-c-k akash-c-k deleted the fix/saved-payment-methods branch March 20, 2024 08:18
akash-c-k pushed a commit that referenced this pull request Mar 20, 2024
@semantic-release-bot
chore(release): 0.33.10 [skip ci]
440b826 
## [0.33.10](v0.33.9...v0.33.10) (2024-03-20)

### Bug Fixes

* saved Payment Method stuck in loading state and Card Holder Name for every saved card ([#241](#241)) ([6b1bc56](6b1bc56))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@akash-c-k akash-c-k akash-c-k approved these changes

@vsrivatsa-juspay vsrivatsa-juspay vsrivatsa-juspay approved these changes

@prafulkoppalkar prafulkoppalkar prafulkoppalkar left review comments

Assignees

@ArushKapoorJuspay ArushKapoorJuspay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ArushKapoorJuspay @PritishBudhiraja @prafulkoppalkar @akash-c-k @vsrivatsa-juspay