Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: payment-management added #392

Merged
merged 4 commits into from
Jul 8, 2024
Merged

feat: payment-management added #392

merged 4 commits into from
Jul 8, 2024

Conversation

sakksham7
Copy link
Contributor

@sakksham7 sakksham7 commented May 21, 2024 •
edited by ArushKapoorJuspay
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Summary

This PR introduces a new feature called Payment Method Management, which allows customers to manage (delete) their saved payment methods directly from their account.

Details

  • New Widget: Payment Method Management

    • Customers can view and delete their saved payment methods.
    • This widget operates independently of the usual payment flow.

Key Points

  • Ephemeral Key Usage:

    • Unlike the traditional payment flow that relies on clientSecret, this widget uses an ephemeralKey.
    • The ephemeralKey has limited validity and is specifically designed for updating or deleting payment methods.
    • It cannot be used to make a payment, ensuring secure and restricted access.

Features

  • View Payment Methods: Customers can see a list of their saved payment methods.
  • Delete Payment Methods: Customers can securely delete any of their saved payment methods.

Technical Changes

  • Implemented the Payment Method Management widget.
  • Integrated ephemeralKey handling for secure update and delete operations.
  • Ensured the widget operates independently of the payment flow to enhance user experience and security.

How did you test it?

imported PaymentManagement from react-orca-js

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sakksham7 sakksham7 self-assigned this May 21, 2024
@github-actions github-actions bot added the S-conventions-not-followed Some Github conventions not followed label May 21, 2024
@sakksham7 sakksham7 changed the title Payment management feat: payment-management added May 21, 2024
@github-actions github-actions bot removed the S-conventions-not-followed Some Github conventions not followed label May 21, 2024
@sakksham7 sakksham7 linked an issue May 21, 2024 that may be closed by this pull request
Payment management UI POC #373
Closed
@PritishBudhiraja PritishBudhiraja added Ready for Review PR with label Ready for Review should only be reviewed. DO NOT MERGE Use this label if you want your PR to restrict from merging and removed Ready for Review PR with label Ready for Review should only be reviewed. labels May 21, 2024
@PritishBudhiraja PritishBudhiraja added Ready for Review PR with label Ready for Review should only be reviewed. and removed DO NOT MERGE Use this label if you want your PR to restrict from merging labels Jun 28, 2024
@sakksham7 sakksham7 removed the request for review from prafulkoppalkar July 4, 2024 06:17
seekshiva
seekshiva requested changes Jul 4, 2024
View reviewed changes
src/CardUtils.res Show resolved Hide resolved
src/Components/SavedMethodItem.res Outdated Show resolved Hide resolved
src/Components/SavedPaymentManagement.res Show resolved Hide resolved
src/Hooks/CommonHooks.res Outdated Show resolved Hide resolved
src/LoaderController.res Outdated Show resolved Hide resolved
src/PaymentManagementLazy.res Show resolved Hide resolved
vsrivatsa-juspay
vsrivatsa-juspay requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@vsrivatsa-juspay vsrivatsa-juspay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logging changes needed

@PritishBudhiraja PritishBudhiraja merged commit ef1c605 into main Jul 8, 2024
3 checks passed
@PritishBudhiraja PritishBudhiraja deleted the payment-management branch July 8, 2024 12:06
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label Jul 8, 2024
akash-c-k pushed a commit that referenced this pull request Jul 8, 2024
@semantic-release-bot
chore(release): 0.73.0 [skip ci]
a62635c 
# [0.73.0](v0.72.7...v0.73.0) (2024-07-08)

### Features

* payment-management added ([#392](#392)) ([ef1c605](ef1c605))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArushKapoorJuspay ArushKapoorJuspay ArushKapoorJuspay left review comments

@seekshiva seekshiva seekshiva approved these changes

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@vsrivatsa-juspay vsrivatsa-juspay vsrivatsa-juspay approved these changes

Assignees

@PritishBudhiraja PritishBudhiraja

@prafulkoppalkar prafulkoppalkar

@sakksham7 sakksham7

Labels
Closed Label will be automatically added when the PR will get merged to main Ready for Review PR with label Ready for Review should only be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Payment management UI POC
6 participants
@sakksham7 @vsrivatsa-juspay @seekshiva @PritishBudhiraja @ArushKapoorJuspay @prafulkoppalkar