-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR] remove unused function for merchant connector account #1998
Comments
hey @Narayanbhat166 i like to work on this |
Hello @Narayanbhat166 and @tharun208. I am looking for opportunities to contribute. Could I help on this issue? |
Hey @tharun208, Sure you can work on this. Apologies for the delayed response! |
Hey @dalprahcd, thanks for showing interest. This is a fairly simple issue. You can look into #2039 |
Hey @tharun208, just wanted to know if you'd started any work on this issue, since there's been no activity on this thread, and an open PR by @heysharan that closes this issue (#2753). Please let us know in either case, we'll proceed accordingly. |
hey @SanchithHegde can you please assign me this issue. |
Sure @heysharan. Un-assigning @tharun208 due to inactivity. |
Hey @SanchithHegde I have worked on this issue and I have made a PR (#2753), can you please guide me further. |
@heysharan You can also remove any functions called in the code you removed, one of which is |
@SanchithHegde Thank you ! |
Hi @heysharan. We recently reused this function in one of our dependent crates. Deleting it now would break the crates which are dependent on the router library. Sorry to inform, but this PR can be closed. |
Hi @Narayanbhat166 Thank you for your update. |
Closing this. |
The function
find_merchant_connector_account_by_merchant_id_connector_name
which was used to query the merchant connector account ( stripe, adyen etc ) is no longer needed. This can be removed safely. Remove all the child functions and ensure that the project compiles.hyperswitch/crates/router/src/db/merchant_connector_account.rs
Line 214 in f0cc0fb
The text was updated successfully, but these errors were encountered: