Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] remove unused function for merchant connector account #1998

Closed
Narayanbhat166 opened this issue Aug 23, 2023 · 13 comments
Closed
Assignees
Labels
C-refactor Category: Refactor E-easy Effort: Should be easy to implement and would make a good first PR good first issue Good for newcomers

Comments

@Narayanbhat166
Copy link
Member

The function find_merchant_connector_account_by_merchant_id_connector_name which was used to query the merchant connector account ( stripe, adyen etc ) is no longer needed. This can be removed safely. Remove all the child functions and ensure that the project compiles.

async fn find_merchant_connector_account_by_merchant_id_connector_name(

@Narayanbhat166 Narayanbhat166 added E-easy Effort: Should be easy to implement and would make a good first PR C-refactor Category: Refactor good first issue Good for newcomers labels Aug 23, 2023
@tharun208
Copy link

hey @Narayanbhat166 i like to work on this

@dalprahcd
Copy link
Contributor

Hello @Narayanbhat166 and @tharun208. I am looking for opportunities to contribute. Could I help on this issue?

@Narayanbhat166
Copy link
Member Author

Hey @tharun208, Sure you can work on this. Apologies for the delayed response!

@Narayanbhat166
Copy link
Member Author

Hey @dalprahcd, thanks for showing interest. This is a fairly simple issue. You can look into #2039

@SanchithHegde
Copy link
Member

Hey @tharun208, just wanted to know if you'd started any work on this issue, since there's been no activity on this thread, and an open PR by @heysharan that closes this issue (#2753). Please let us know in either case, we'll proceed accordingly.

@heysharan
Copy link

hey @SanchithHegde can you please assign me this issue.

@SanchithHegde
Copy link
Member

Sure @heysharan.

Un-assigning @tharun208 due to inactivity.

@SanchithHegde SanchithHegde assigned heysharan and unassigned tharun208 Nov 11, 2023
@heysharan
Copy link

heysharan commented Nov 12, 2023

Hey @SanchithHegde I have worked on this issue and I have made a PR (#2753), can you please guide me further.

@SanchithHegde
Copy link
Member

@heysharan You can also remove any functions called in the code you removed, one of which is MerchantConnectorAccount::find_by_merchant_id_connector_name(). Once done, ensure that the project compiles without any warnings.

@heysharan
Copy link

@SanchithHegde Thank you !

@Narayanbhat166
Copy link
Member Author

Hi @heysharan. We recently reused this function in one of our dependent crates. Deleting it now would break the crates which are dependent on the router library. Sorry to inform, but this PR can be closed.

@heysharan
Copy link

Hi @Narayanbhat166 Thank you for your update.

@SanchithHegde
Copy link
Member

Closing this.

@SanchithHegde SanchithHegde closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-refactor Category: Refactor E-easy Effort: Should be easy to implement and would make a good first PR good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants