Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: [Bitpay] Use connector_response_reference_id as reference to merchant #2325

Closed
2 tasks done
Sakilmostak opened this issue Sep 22, 2023 · 9 comments · Fixed by #2591
Closed
2 tasks done
Assignees
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants

Comments

@Sakilmostak
Copy link
Contributor

📝 Feature Description

  • Reference id are used to map transactions in the connector’s dashboard.
  • Hyperswitch manages several reference ids, such as payment_id, attempt_id, and connector_transaction_id for a single transaction.
  • However, merchants may encounter uncertainty when determining which ID to utilize in the connector dashboard to identify the payment.

🔨 Possible Implementation

  • When we receive a response from the connector for the payment, we deserialize it and populate the response field in RouterData.
  • For the TransactionResponse type, we must fill the connector_response_reference_id with a corresponding reference id for the merchant to identify the transaction.
  • One might need to have exposure to api docs of the connector for which it is being implemented to decide what to fill in connector_response_reference_id.
  • You can check this PR for further reference feat(connector): [Stripe, Adyen, Checkout] Add reference ID support for retries #1735

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

📦 Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

✨ Are you willing to submit a PR?

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Sep 22, 2023
@Sakilmostak Sakilmostak changed the title [FEATURE]: [Bitpay] Use connector_response_reference_id as reference to merchant [FEATURE]: [Bitpay] Use connector_response_reference_id as reference to merchant Sep 22, 2023
@VedantKhairnar VedantKhairnar added the good first issue Good for newcomers label Sep 28, 2023
@tarunsinghofficial
Copy link

I'm happy to work on this issue, so kindly assign me this issue.
Thanks

@SanchithHegde
Copy link
Member

Hey @tarunsinghofficial, since you're already assigned to #2332, we'll leave this open to other contributors for now. You may pick this up once your work on #2332 is completed, and if no other contributors have expressed interest on this. I hope that's fine by you.

@ashh1215
Copy link
Contributor

ashh1215 commented Oct 4, 2023

Hey @SanchithHegde I'd like to work on this issue. Please assign it to me.

@AkshayaFoiger
Copy link
Contributor

Hey @ashh1215, sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

@AkshayaFoiger AkshayaFoiger removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 5, 2023
@VedantKhairnar
Copy link
Collaborator

Hey @ashh1215 ,
Let us know if you face any issues. Happy to help! : )

@ashh1215
Copy link
Contributor

ashh1215 commented Oct 8, 2023

Hey @VedantKhairnar
So I was going though the Bitpay documentation to figure out what they're using as the reference id.
Problem is that I've gone through a lot of different areas in the documentation, but haven't been able to find one place where all the variables that are being used in the Hyperswitch code match with those present in the documentation.
I wanted to know whether to proceed with whatever I've found, or whether you could guide me to the correct documentation.

@Sakilmostak
Copy link
Contributor Author

Hello @ashh1215 you can go through the invoice section of this Bitpay's API reference doc to check how we are interacting with their API.

@VedantKhairnar
Copy link
Collaborator

Hey @ashh1215 ,
Just checking in - are you working on it?
Let us know if you need any help.

@ashh1215
Copy link
Contributor

Hey @VedantKhairnar
Yeah, I'm working on it. I should be done soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants