feat(connector): [Stripe, Adyen, Checkout] Add reference ID support for retries #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-harsha-vardhan
added
A-connector-integration
SanchithHegde
changed the title
Narayanbhat166
approved these changes
Jul 20, 2023
Abhicodes-crypto
approved these changes
Jul 20, 2023
| redirection_data, | ||
| mandate_reference: None, | ||
| connector_metadata: None, | ||
| network_txn_id: None, | ||
| connector_response_reference_id: None, | ||
| connector_response_reference_id: Some( | ||
| item.response.reference.unwrap_or(item.response.id), |
There was a problem hiding this comment.
Should this be an error ? Because it might break logic.
There was a problem hiding this comment.
We'll try to find our reference id, if it's not available we'll send connector's id. This shouldn't break the flow anyway because we are not using it anywhere except sending the value in payments response.
ArjunKarthik
approved these changes
Jul 25, 2023
SanchithHegde
removed
the
S-waiting-on-review
This was referenced Sep 21, 2023
Closed
Closed
This was referenced Sep 22, 2023
Closed
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
To enable retries for connector, we need to add support of connector_request_reference_id and connector_response_reference_id
Add connector_request_reference_id, connector_response_reference_id support for stripe, adyen and checkout connectors
reference for connector_request_reference_id -> #1627
reference for connector_response_reference_id -> #1664
Additional Changes
Motivation and Context
How did you test it?
Unit tests
Stripe
Adyen
Checkout
Manual Testing
Without config set
With config set
Checklist
cargo +nightly fmt --allcargo clippy