Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: [Iatapay] Use connector_response_reference_id as reference to merchant #2333

Closed
2 tasks done
Sakilmostak opened this issue Sep 22, 2023 · 15 comments · Fixed by #2524
Closed
2 tasks done

[FEATURE]: [Iatapay] Use connector_response_reference_id as reference to merchant #2333

Sakilmostak opened this issue Sep 22, 2023 · 15 comments · Fixed by #2524
Assignees
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions

Comments

@Sakilmostak
Copy link
Contributor

📝 Feature Description

  • Reference id are used to map transactions in the connector’s dashboard.
  • Hyperswitch manages several reference ids, such as payment_id, attempt_id, and connector_transaction_id for a single transaction.
  • However, merchants may encounter uncertainty when determining which ID to utilize in the connector dashboard to identify the payment.

🔨 Possible Implementation

  • When we receive a response from the connector for the payment, we deserialize it and populate the response field in RouterData.
  • For the TransactionResponse type, we must fill the connector_response_reference_id with a corresponding reference id for the merchant to identify the transaction.
  • One might need to have exposure to api docs of the connector for which it is being implemented to decide what to fill in connector_response_reference_id.
  • You can check this PR for further reference feat(connector): [Stripe, Adyen, Checkout] Add reference ID support for retries #1735

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

📦 Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

✨ Are you willing to submit a PR?

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Sep 22, 2023
@Sakilmostak Sakilmostak changed the title [FEATURE]: [Iatapay] Use connector_response_reference_id as reference to merchant [FEATURE]: [Iatapay] Use connector_response_reference_id as reference to merchant Sep 22, 2023
@VedantKhairnar VedantKhairnar added the good first issue Good for newcomers label Sep 28, 2023
@Kota-Karthik
Copy link

@AkshayaFoiger @Sakilmostak
I would be delighted to work on this issue
so kindly assign me this issue
Thank You : )

@AkshayaFoiger
Copy link
Contributor

Hey @Kota-Karthik, I see that you're already assigned to #2351. For now, we'll leave this issue open to any other interested contributors. You may pick this up once your work on #2351 is completed, and if no other contributors have expressed interest on this. I hope that's fine by you

@ALLENGJOSE
Copy link

@AkshayaFoiger @Sakilmostak Can I please work on this issue?

@SanchithHegde
Copy link
Member

Sure @ALLENGJOSE, I'll assign this to you. Let us know in case you have any questions, on this issue thread or on our Discord server.

@SanchithHegde SanchithHegde removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 3, 2023
@ALLENGJOSE
Copy link

Thanks. Working on it.

@ALLENGJOSE
Copy link

@SanchithHegde I am blank on this. Can you please help me with this as to how to proceed?

@AkshayaFoiger
Copy link
Contributor

AkshayaFoiger commented Oct 4, 2023

Hello @ALLENGJOSE ,
Thank you for getting in touch.
We would kindly recommend proceeding by configuring Hyperswitch on your local machine.

To give you a better idea on how to resolve this issue, I would like to elucidate how it has been handled in the context of Adyen. On examining the Adyen documentation regarding payment requests, it is evident that they accept a field known as reference within their API requests for creating a transaction. This reference serves as a means to specifically identify and reference individual payments, and thus, it can been aptly designated as a connector_response_reference_id. We have accordingly made the necessary modifications to the connector/adyen/transformer.rs file, to include reference field in payment responses. I recommend reviewing the details of these changes in this associated Pull Request.

We are hoping to do similar implementation for Iatapay.

I hope this information proves helpful. In case you have any further queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

@ALLENGJOSE ALLENGJOSE removed their assignment Oct 4, 2023
@ALLENGJOSE
Copy link

I am sorry. I am not able to understand this . Therefore I am Unassigning myself.

@prasunna09
Copy link
Contributor

prasunna09 commented Oct 4, 2023

@SanchithHegde I am blank on this. Can you please help me with this as to how to proceed?

Hi @ALLENGJOSE, Can you please tell us what issue you were facing earlier? Is it with understanding the issue or how to do the local setup of hyperswitch?
We would be happy to get on a call and help you out!

@AkshayaFoiger AkshayaFoiger added the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 4, 2023
@Nittzza
Copy link

Nittzza commented Oct 4, 2023

@Sakilmostak Hi i would like to work on this issue. Can i please be assigned thanks.

@AkshayaFoiger AkshayaFoiger removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 4, 2023
@AkshayaFoiger
Copy link
Contributor

AkshayaFoiger commented Oct 4, 2023

Hey @Nittzza , sure! I've assigned this to you.
Please refer api docs of Iatapay here

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

@Nittzza
Copy link

Nittzza commented Oct 4, 2023

Thanks, working on it.

@VedantKhairnar
Copy link
Contributor

Hey @Nittzza ,
Let us know if you face any issues. Happy to help! : )

@Nittzza
Copy link

Nittzza commented Oct 6, 2023

I have set up hyperswitch on my local system so far. I'll let you know about any issues i face thanks.

@swangi-kumari
Copy link
Contributor

Hello @Nittzza ,
This issue is already resolved by @SoumyoPurkayastha in this pr 2524.
If you are interested, we will assign you with other open issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants