Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: [Square] Use connector_response_reference_id as reference to merchant #2349

Closed
2 tasks done
Sakilmostak opened this issue Sep 22, 2023 · 11 comments · Fixed by #2434
Closed
2 tasks done

[FEATURE]: [Square] Use connector_response_reference_id as reference to merchant #2349

Sakilmostak opened this issue Sep 22, 2023 · 11 comments · Fixed by #2434
Assignees
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants

Comments

@Sakilmostak
Copy link
Contributor

📝 Feature Description

  • Reference id are used to map transactions in the connector’s dashboard.
  • Hyperswitch manages several reference ids, such as payment_id, attempt_id, and connector_transaction_id for a single transaction.
  • However, merchants may encounter uncertainty when determining which ID to utilize in the connector dashboard to identify the payment.

🔨 Possible Implementation

  • When we receive a response from the connector for the payment, we deserialize it and populate the response field in RouterData.
  • For the TransactionResponse type, we must fill the connector_response_reference_id with a corresponding reference id for the merchant to identify the transaction.
  • One might need to have exposure to api docs of the connector for which it is being implemented to decide what to fill in connector_response_reference_id.
  • You can check this PR for further reference feat(connector): [Stripe, Adyen, Checkout] Add reference ID support for retries #1735

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

📦 Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

✨ Are you willing to submit a PR?

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Sep 22, 2023
@Sakilmostak Sakilmostak changed the title [FEATURE]: [Square] Use connector_response_reference_id as reference to merchant [FEATURE]: [Square] Use connector_response_reference_id as reference to merchant Sep 22, 2023
@VedantKhairnar VedantKhairnar added the good first issue Good for newcomers label Sep 28, 2023
@Kota-Karthik
Copy link

@AkshayaFoiger
I would be delighted to work on this issue
so kindly assign me this
Thank You : )

@AkshayaFoiger
Copy link
Contributor

Hey @Kota-Karthik, I see that you're already assigned to #2351. For now, we'll leave this issue open to any other interested contributors. You may pick this up once your work on #2351 is completed, and if no other contributors have expressed interest on this. I hope that's fine by you

@work-mohit
Copy link

@AkshayaFoiger I would love to work on this issue.

@manirht
Copy link

manirht commented Oct 1, 2023

I'm interested in doing this issue so kindly assign me this
Thank You : )

@AkshayaFoiger
Copy link
Contributor

Hey @manirht, I see that you're already assigned to #2248. For now, we'll leave this issue open to any other interested contributors. You may pick this up once your work on #2248 is completed, and if no other contributors have expressed interest on this. I hope that's fine by you

@AkshayaFoiger AkshayaFoiger removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 1, 2023
@AkshayaFoiger
Copy link
Contributor

Hey @work-mohit, sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

@work-mohit work-mohit removed their assignment Oct 2, 2023
@VedantKhairnar
Copy link
Contributor

Hey @AkshayaFoiger
Will you please assign this me if Mohit isn't taking this up?
Thanks in advance!

@bhimeshagrawal
Copy link
Contributor

Hi @AkshayaFoiger
I would like to work on it, if its available

@AkshayaFoiger
Copy link
Contributor

Hey @VedantKhairnar, sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

@AkshayaFoiger
Copy link
Contributor

Hi @AkshayaFoiger I would like to work on it, if its available

Hello @bhimeshagrawal, since this issue has already been assigned, could you kindly review #2205, or there are additional similar issues that require attention, I would be pleased to assign them to you

@bhimeshagrawal
Copy link
Contributor

Hi @AkshayaFoiger I would like to work on it, if its available

Hello @bhimeshagrawal, since this issue has already been assigned, could you kindly review #2205, or there are additional similar issues that require attention, I would be pleased to assign them to you

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants