Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] : add check for payment_method_type in is_preprocessing_required_for_wallets function #4787

Open
2 tasks done
AkshayaFoiger opened this issue May 28, 2024 · 0 comments
Labels
C-bug Category: Bug S-awaiting-triage Status: New issues that have not been assessed yet

Comments

@AkshayaFoiger
Copy link
Contributor

AkshayaFoiger commented May 28, 2024

Bug Description

Currently preprocessing is called for all types of wallets in Trustpay and Payme . As a result for wallets such as Wechatpay that is not implemented in Trustpay, still hits the connector during preprocessing call and results in a de-serialization error

Expected Behavior

is_preprocessing_required_for_wallets , must check for wallet types

Actual Behavior

is_preprocessing_required_for_wallets , doesn't check for wallet types

Steps To Reproduce

Provide an unambiguous set of steps to reproduce this bug. Include code or configuration to reproduce, if relevant.

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'

Context For The Bug

request_id: 018fbeb3-f9c2-7e03-a8ea-8fb37dd05f1f

extra_error : {"error":{"type":"api","message":"Something went wrong","code":"HE_00"}}
├╴at crates/router/src/services/api.rs:1039:14

├─:arrow_forward: {"error":{"type":"server_not_available","code":"HE_00","message":"Something went wrong"}}
│ ╰╴at crates/router/src/core/errors/utils.rs:314:17

├─:arrow_forward: Failed to deserialize connector response
│ ╰╴at crates/router/src/connector/trustpay.rs:510:14

├─:arrow_forward: Failed to parse struct: TrustpayCreateIntentResponse
│ ├╴at /router/crates/common_utils/src/ext_traits.rs:194:14
│ ╰╴Unable to parse router::connector::trustpay::transformers::TrustpayCreateIntentResponse from bytes b"{"status":0,"description":"payment intent successfully created","instanceId":"6NlXJvhLdKbx4mG-zmKcIQ","secrets":{"display":"dlhjVEWBFNSIzikvG7QDz6-Z-FIXkfyRCIxqs8pdcB-d1eLHMEqMkJjfnlYRAVLhJtRHj7ySJ_3MpeM9I9eaZZeDX8dAI1nbfQEcBehjMsvmxaG16Hc0KlVbQKH6EZH_","payment":"k4_qIbx2VPlBu9h2102IP2mXWxF9IQeFoLHTMKKUgVpHD51qZpWG6UB5htsDCxRBCoRxAquIsfQwrfCWqsqLdcDW4XGV07L9d_-bD2__96YrMzKIUYbR1jh6p9fkpxt_"}}"

╰─:arrow_forward: no variant of enum InitResultData found in flattened data at line 1 column 396
╰╴at /router/crates/common_utils/src/ext_traits.rs:194:14
message : [SERVER_WRAP - EVENT] router::services::api
request_url_path : /payments/pay_Lixk4mVuPrHqpSJ6JjAx/confirm
*request_method : *POST
*flow :*PaymentsConfirm
*line : *1292
*merchant_id : *postman_merchant_GHAction_62cf6f50-0045-49fd-a4dc-ac998e513a0a
*hostname: *bach-2024-05-24-1-549769dd66-8f2dp

Environment

Are you using hyperswitch hosted version? Yes/No
If yes, please provide the value of the x-request-id response header to help us debug your issue.

If not (or if building/running locally), please provide the following details:

  1. Operating System or Linux distribution:
  2. Rust version (output of rustc --version): ``
  3. App version (output of cargo r --features vergen -- --version): ``

Have you spent some time checking if this bug has been raised before?

  • I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

None

@AkshayaFoiger AkshayaFoiger added C-bug Category: Bug S-awaiting-triage Status: New issues that have not been assessed yet labels May 28, 2024
@JeevaRamu0104 JeevaRamu0104 linked a pull request Jun 4, 2024 that will close this issue
14 tasks
@JeevaRamu0104 JeevaRamu0104 removed a link to a pull request Jun 4, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Bug S-awaiting-triage Status: New issues that have not been assessed yet
Projects
None yet
Development

No branches or pull requests

1 participant