feat(Connector):[Adyen]Implement ACH Direct Debits for Adyen #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swangi-kumari
added
A-connector-compatibility
ArjunKarthik
added
A-connector-integration
ArjunKarthik
removed
the
S-waiting-on-review
ArjunKarthik
requested changes
May 3, 2023
| @@ -1098,7 +1179,7 @@ impl<'a> | |||
| shopper_locale, | |||
| billing_address: None, | |||
| delivery_address: None, | |||
| country_code: country, | |||
| country_code: None, | |||
There was a problem hiding this comment.
Why we are making country as None here?
There was a problem hiding this comment.
This was resolved without any comments/changes?
swangi-kumari
changed the title
jagan-jaya
reviewed
May 5, 2023
ArjunKarthik
previously approved these changes
May 8, 2023
ArjunKarthik
previously approved these changes
May 8, 2023
jagan-jaya
previously approved these changes
May 8, 2023
swangi-kumari
changed the title
ArjunKarthik
added
R-waiting-on-L2
swangi-kumari
changed the title
jarnura
previously approved these changes
May 9, 2023
jarnura
added
S-waiting-on-author
jagan-jaya
dismissed stale reviews from jarnura, ArjunKarthik, and themself
via
c2a960c
jagan-jaya
approved these changes
May 9, 2023
jagan-jaya
added
S-ready-for-merge
and removed
S-waiting-on-author
jarnura
approved these changes
May 9, 2023
SanchithHegde
removed
R-L1-completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Implemented Bank Debit Data for Adyen Payment Method.
Additional Changes
Motivation and Context
In Adyen connector ACH Bank Debits was not implemented, but it is important payment method which is needed in market so I implemented it.
How did you test it?
I tested it using Postman.
Checklist
cargo +nightly fmt --allcargo clippy