Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mandate): only trigger mandate procedure on successful connector call #1122

Merged
merged 2 commits into from
May 11, 2023
Merged

fix(mandate): only trigger mandate procedure on successful connector call #1122

merged 2 commits into from
May 11, 2023

Conversation

NishantJoshi00
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Consider a scenario where, we are creating a mandate, and there was a failure at the connector side, even in that case the mandate is created.
The bug prominently affects single_use mandate. Where, in the recurring payment, if there was a failure on the connector side, the system still marks the mandate as done

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Hackathon

How did you test it?

Postman and Manual

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@NishantJoshi00 NishantJoshi00 added A-core Area: Core flows C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 11, 2023
@NishantJoshi00 NishantJoshi00 added this to the May 2023 Release milestone May 11, 2023
@NishantJoshi00 NishantJoshi00 self-assigned this May 11, 2023
@NishantJoshi00 NishantJoshi00 requested a review from a team as a code owner May 11, 2023 08:25
@NishantJoshi00 NishantJoshi00 linked an issue May 11, 2023 that may be closed by this pull request
[BUG] A connector side failure still executes mandate procedure #1121
Closed
2 tasks
SanchithHegde
SanchithHegde reviewed May 11, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

crates/router/src/core/mandate.rs Outdated Show resolved Hide resolved
@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 11, 2023
@SanchithHegde SanchithHegde added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels May 11, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer labels May 11, 2023
@jarnura jarnura added this pull request to the merge queue May 11, 2023
Merged via the queue into main with commit a904d2b May 11, 2023
5 checks passed
@SanchithHegde SanchithHegde removed S-ready-for-merge R-L1-completed Review: L1 Review completed labels May 11, 2023
@SanchithHegde SanchithHegde deleted the fix/mandate-for-err-resp branch May 11, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@NishantJoshi00 NishantJoshi00

Labels
A-core Area: Core flows C-bug Category: Bug
Projects
None yet
Milestone
May 2023 Release
Development

Successfully merging this pull request may close these issues.

[BUG] A connector side failure still executes mandate procedure
3 participants
@NishantJoshi00 @jarnura @SanchithHegde