Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle unique constraint violation error gracefully #1202

Merged
merged 2 commits into from
May 18, 2023
Merged

fix: handle unique constraint violation error gracefully #1202

merged 2 commits into from
May 18, 2023

Conversation

manoj-juspay
Copy link
Contributor

Type of Change

  • Bugfix

Description

In case tokenized entry is already present don't throw Unique violation error

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@manoj-juspay manoj-juspay added A-process-tracker Area: Process tracker C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payment-methods Area: Payment Methods labels May 18, 2023
@manoj-juspay manoj-juspay requested a review from a team as a code owner May 18, 2023 11:37
@manoj-juspay manoj-juspay self-assigned this May 18, 2023
Narayanbhat166
Narayanbhat166 previously approved these changes May 18, 2023
View reviewed changes
@jarnura jarnura enabled auto-merge May 18, 2023 14:10
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 18, 2023
@jarnura jarnura added this pull request to the merge queue May 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 18, 2023
@jarnura jarnura added this pull request to the merge queue May 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 18, 2023
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue May 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 18, 2023
@SanchithHegde SanchithHegde changed the title bug: Handle Unique Violation error gracefully fug: handle unique constraint violation error gracefully May 18, 2023
@SanchithHegde SanchithHegde changed the title fug: handle unique constraint violation error gracefully fix: handle unique constraint violation error gracefully May 18, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue May 18, 2023
Merged via the queue into main with commit b3fd174 May 18, 2023
8 checks passed
@SanchithHegde SanchithHegde deleted the tokenize_pt_insert_err_handling branch May 18, 2023 17:48
SamraatBansal pushed a commit that referenced this pull request May 19, 2023
@manoj-juspay @SamraatBansal
fix: handle unique constraint violation error gracefully (#1202)
d2a1b96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@NishantJoshi00 NishantJoshi00 NishantJoshi00 approved these changes

@Abhicodes-crypto Abhicodes-crypto Awaiting requested review from Abhicodes-crypto

Assignees

@manoj-juspay manoj-juspay

Labels
A-payment-methods Area: Payment Methods A-process-tracker Area: Process tracker C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@manoj-juspay @jarnura @SanchithHegde @Narayanbhat166 @NishantJoshi00 @Abhicodes-crypto