Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Noon] Add Card Mandates and Webhooks Support #1243

Merged
merged 25 commits into from
Jun 5, 2023
Merged

feat(connector): [Noon] Add Card Mandates and Webhooks Support #1243

merged 25 commits into from
Jun 5, 2023

Conversation

SamraatBansal
Copy link
Contributor

@SamraatBansal SamraatBansal commented May 23, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add Support for

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

An additional filed order_category can be accepted in Metadata in PaymentsCreate Which is populated in PaymentsAuthorizeRouterData

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SamraatBansal SamraatBansal requested review from a team as code owners May 23, 2023 12:15
@SamraatBansal SamraatBansal self-assigned this May 23, 2023
@SamraatBansal SamraatBansal added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-api-contract-changes Metadata: This PR involves API contract changes R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 23, 2023
@SamraatBansal SamraatBansal changed the base branch from main to noon-cards-integ May 23, 2023 12:16
jagan-jaya
jagan-jaya requested changes May 23, 2023
View reviewed changes
crates/api_models/src/payments.rs Show resolved Hide resolved
crates/router/src/connector/noon.rs Show resolved Hide resolved
crates/router/src/connector/noon.rs Outdated Show resolved Hide resolved
crates/router/src/connector/noon/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/noon/transformers.rs Show resolved Hide resolved
crates/router/src/core/payments/helpers.rs Show resolved Hide resolved
@SamraatBansal SamraatBansal changed the base branch from noon-cards-integ to main May 23, 2023 14:17
@jarnura jarnura added this to the May 2023 Release milestone May 25, 2023
@jarnura jarnura removed this pull request from the merge queue due to a manual request May 25, 2023
ArjunKarthik
ArjunKarthik previously approved these changes May 29, 2023
View reviewed changes
@ArjunKarthik ArjunKarthik dismissed stale reviews from jarnura, jagan-jaya, and themself via 614d628 May 29, 2023 06:15
@ArjunKarthik ArjunKarthik requested review from a team and ashokkjag as code owners May 29, 2023 06:15
ArjunKarthik
ArjunKarthik previously approved these changes May 29, 2023
View reviewed changes
jagan-jaya
jagan-jaya previously approved these changes May 30, 2023
View reviewed changes
@jagan-jaya jagan-jaya enabled auto-merge May 30, 2023 05:42
@SanchithHegde SanchithHegde added the S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author label May 31, 2023
@jagan-jaya jagan-jaya added this pull request to the merge queue Jun 5, 2023
Merged via the queue into main with commit ba8a17d Jun 5, 2023
6 checks passed
@SanchithHegde SanchithHegde deleted the noon-webhooks-integ branch June 5, 2023 10:44
@SanchithHegde SanchithHegde removed S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author S-ready-for-merge labels Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vspecky vspecky vspecky left review comments

@jagan-jaya jagan-jaya jagan-jaya approved these changes

@jarnura jarnura jarnura approved these changes

@HyperSwitchers HyperSwitchers HyperSwitchers approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik left review comments

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@SamraatBansal SamraatBansal

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes P-high Priority: High
Projects
None yet
Milestone
May 2023 Release
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@SamraatBansal @jagan-jaya @ArjunKarthik @jarnura @vspecky @HyperSwitchers @SanchithHegde