Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Mollie] Implement Przelewy24 and BancontactCard Bank Redirects for Mollie connector #1303

Merged
merged 15 commits into from
Jul 1, 2023
Merged

feat(connector): [Mollie] Implement Przelewy24 and BancontactCard Bank Redirects for Mollie connector #1303

merged 15 commits into from
Jul 1, 2023

Conversation

swangi-kumari
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Using postman and UI test
Screenshot 2023-05-29 at 4 47 44 PM

For Przelewy24
Screenshot 2023-05-26 at 4 38 27 PM
Screenshot 2023-05-26 at 4 38 38 PM
Screenshot 2023-05-26 at 4 38 44 PM
Screenshot 2023-05-26 at 6 54 20 PM

For bancontact card
Screenshot 2023-05-29 at 11 17 44 AM
Screenshot 2023-05-29 at 11 18 25 AM
Screenshot 2023-05-29 at 11 18 40 AM
Screenshot 2023-05-29 at 11 52 51 AM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 29, 2023
@swangi-kumari swangi-kumari self-assigned this May 29, 2023
@swangi-kumari swangi-kumari requested review from a team as code owners May 29, 2023 11:28
@jagan-jaya jagan-jaya added the S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author label Jun 8, 2023
ArjunKarthik
ArjunKarthik previously approved these changes Jun 28, 2023
View reviewed changes
@ArjunKarthik ArjunKarthik removed the S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author label Jun 28, 2023
@ArjunKarthik ArjunKarthik added the low-risk label to track PRs which might have less impact on hyperswitch after merge label Jun 28, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Jul 1, 2023
@SanchithHegde SanchithHegde added S-ready-for-merge and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jul 1, 2023
Merged via the queue into main with commit f091be6 Jul 1, 2023
6 checks passed
@SanchithHegde SanchithHegde deleted the mollie_bankRedirects branch July 1, 2023 10:31
@SanchithHegde SanchithHegde removed S-ready-for-merge low-risk label to track PRs which might have less impact on hyperswitch after merge labels Jul 1, 2023
@jarnura jarnura added this to the July 2023 Release milestone Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jagan-jaya jagan-jaya Awaiting requested review from jagan-jaya

@Narayanbhat166 Narayanbhat166 Awaiting requested review from Narayanbhat166

Assignees

@swangi-kumari swangi-kumari

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
July 2023 Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@swangi-kumari @ArjunKarthik @SanchithHegde @jagan-jaya @jarnura