-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(db): implement DisputeInterface
for MockDb
#1345
Merged
SanchithHegde
merged 23 commits into
juspay:main
from
Exosyz:fix-1190-mockdb-disputeinterface
Jun 5, 2023
Merged
feat(db): implement DisputeInterface
for MockDb
#1345
SanchithHegde
merged 23 commits into
juspay:main
from
Exosyz:fix-1190-mockdb-disputeinterface
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ute_id for mockdb
…connector_dispute_id
DisputeInterface
for MockDb
DisputeInterface
for MockDb
DisputeInterface
for MockDb
DisputeInterface
for MockDb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @Exosyz! Appreciate the detailed tests!
SanchithHegde
approved these changes
Jun 4, 2023
sai-harsha-vardhan
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
The main motivation is to have MockDb stubs, help to void mocking, and invocation of external database api's.
For more information check #172
Fixes #1190.
How did you test it?
I created a unit test for all implemented methods
Checklist
cargo +nightly fmt --all
cargo clippy