Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(db): implement DisputeInterface for MockDb #1345

Merged
merged 23 commits into from
Jun 5, 2023
Merged

feat(db): implement DisputeInterface for MockDb #1345

merged 23 commits into from
Jun 5, 2023

Conversation

Exosyz
Copy link
Contributor

@Exosyz Exosyz commented Jun 3, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

The main motivation is to have MockDb stubs, help to void mocking, and invocation of external database api's.
For more information check #172

Fixes #1190.

How did you test it?

I created a unit test for all implemented methods

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

Exosyz added 21 commits May 22, 2023 22:18
@Exosyz
feat(router): add dispute in mockdb
1f49856
@Exosyz
feat(router): implement insert_dispute for mockdb
000a0ab
@Exosyz
feat(router): use cargo fmt
6a08d47
@Exosyz
feat(router): implement update_dispute for mockdb
55fe8fb
@Exosyz
feat(router): implement find_by_merchant_id_payment_id_connector_disp…
e99c379 
…ute_id for mockdb
@Exosyz
feat(router): implement find_disputes_by_merchant_id for mockdb
61fa030
@Exosyz
feat(router): implement find_dispute_by_merchant_id_dispute_id for mo…
c12199c 
…ckdb
@Exosyz
feat(router): implement find_disputes_by_merchant_id_payment_id for m…
fbd7487 
…ockdb
@Exosyz
feat(router): add test to mock db
1a8dab0
@Exosyz
feat(router) implement test_insert_dispute
f42bf58
@Exosyz
feat(router) implement test_find_by_merchant_id_payment_id_connector_…
e06dd65 
…dispute_id
@Exosyz
feat(router) implement test_find_dispute_by_merchant_id_dispute_id
f492b0f
@Exosyz
feat(router) implement test_find_disputes_by_merchant_id_payment_id
eadd5a5
@Exosyz
feat(router) format code
0e1db8e
@Exosyz
feat(router) re-implement find_disputes_by_merchant_id
aa6e2f1
@Exosyz
feat(router) Re factorisation of test_insert_dispute
58091df
@Exosyz
feat(router) Re factorisation of test_find_by_merchant_id_payment_id_…
4a73649 
…connector_dispute_id
@Exosyz
feat(router) Re factorisation of test_find_dispute_by_merchant_id_dis…
4d27bed 
…pute_id
@Exosyz
feat(router) Implement test_find_disputes_by_merchant_id
a0d7df6
@Exosyz
feat(router) Re factorisation of test_find_disputes_by_merchant_id_pa…
fc5164d 
…yment_id
@Exosyz
feat(router) Implement test_update_dispute
7512a24
@Exosyz Exosyz requested a review from a team as a code owner June 3, 2023 20:53
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jun 3, 2023
@Exosyz Exosyz changed the title Implement DisputeInterface for MockDb feat(router) : implement DisputeInterface for MockDb Jun 4, 2023
@SanchithHegde SanchithHegde added A-framework Area: Framework C-feature Category: Feature request or enhancement S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Jun 4, 2023
@SanchithHegde SanchithHegde changed the title feat(router) : implement DisputeInterface for MockDb feat(db): implement DisputeInterface for MockDb Jun 4, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jun 4, 2023
SanchithHegde
SanchithHegde reviewed Jun 4, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @Exosyz! Appreciate the detailed tests!

crates/router/src/db/dispute.rs Outdated Show resolved Hide resolved
crates/router/src/db/dispute.rs Outdated Show resolved Hide resolved
crates/router/src/db/dispute.rs Outdated Show resolved Hide resolved
crates/router/src/db/dispute.rs Outdated Show resolved Hide resolved
crates/router/src/db/dispute.rs Outdated Show resolved Hide resolved
crates/router/src/db/dispute.rs Outdated Show resolved Hide resolved
crates/router/src/db/dispute.rs Show resolved Hide resolved
@SanchithHegde SanchithHegde removed the S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author label Jun 4, 2023
@SanchithHegde SanchithHegde added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jun 4, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Jun 5, 2023
@SanchithHegde SanchithHegde added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 5, 2023
Merged via the queue into juspay:main with commit e5e39a7 Jun 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@lsampras lsampras Awaiting requested review from lsampras

Assignees

@Exosyz Exosyz

Labels
A-framework Area: Framework C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement DisputeInterface for MockDb
3 participants
@Exosyz @SanchithHegde @sai-harsha-vardhan