Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(errors): remove RedisErrorExt #1389

Merged
merged 2 commits into from
Jun 20, 2023
Merged

refactor(errors): remove RedisErrorExt #1389

merged 2 commits into from
Jun 20, 2023

Conversation

Abhicodes-crypto
Copy link
Contributor

@Abhicodes-crypto Abhicodes-crypto commented Jun 8, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

removed unused RedisErrorExt . Let me know if this needs to be used somewhere.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Compiles

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Abhicodes-crypto Abhicodes-crypto added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Jun 8, 2023
@Abhicodes-crypto Abhicodes-crypto self-assigned this Jun 8, 2023
@Abhicodes-crypto Abhicodes-crypto requested a review from a team as a code owner June 8, 2023 10:27
@SanchithHegde SanchithHegde added the A-errors Area: error messages, structure & logging label Jun 13, 2023
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Jun 20, 2023
@Narayanbhat166 Narayanbhat166 removed this pull request from the merge queue due to a manual request Jun 20, 2023
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Jun 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2023
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Jun 20, 2023
Merged via the queue into main with commit 5d51505 Jun 20, 2023
6 checks passed
@SanchithHegde SanchithHegde deleted the rm-redisErrorExt branch June 20, 2023 07:27
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@dracarys18 dracarys18 Awaiting requested review from dracarys18

Assignees

@Abhicodes-crypto Abhicodes-crypto

Labels
A-errors Area: error messages, structure & logging C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Abhicodes-crypto @SanchithHegde @Narayanbhat166