fix(connector): [coinbase][opennode][bitpay] handle error response #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindpatel24
added
C-bug
arvindpatel24
requested review from
jagan-jaya,
ArjunKarthik and
sai-harsha-vardhan
jagan-jaya
requested changes
Jun 12, 2023
| code: response.code, | ||
| message: response.message, | ||
| reason: response.reason, | ||
| code: response.code.unwrap_or(format!("{}", res.status_code)), |
There was a problem hiding this comment.
Suggested change
| code: response.code.unwrap_or(format!("{}", res.status_code)), | |
| code: response.code.unwrap_or_else(|| consts::NO_ERROR_CODE.to_string()), |
jagan-jaya
added
the
S-waiting-on-author
ArjunKarthik
previously approved these changes
Jun 12, 2023
| pub struct OpennodeErrorResponse { | ||
| pub status_code: u16, |
There was a problem hiding this comment.
Previously we had template code for ErrorResponse?
There was a problem hiding this comment.
Hey yes it was there, but I was not aware of that to change.
jagan-jaya
approved these changes
Jun 12, 2023
ArjunKarthik
approved these changes
Jun 12, 2023
arvindpatel24
added
S-ready-for-merge
and removed
R-waiting-on-L1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Handle error response correctly for all crypto connectors.
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy