Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(refunds): modify refund fields to process updating of refund_reason #1544

Merged
merged 9 commits into from
Jul 16, 2023

Conversation

kritikmodi
Copy link
Contributor

@kritikmodi kritikmodi commented Jun 26, 2023

Type of Change

  • Bugfix

Description

The reason field is incorrectly mapped in the core logic so this PR modifies that. Also, the refund_reason field is missing in the db update function so this PR adds that.

Motivation and Context

This PR fixes this issue.

How did you test it?

Tested manually using Postman.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@kritikmodi kritikmodi requested review from a team as code owners June 26, 2023 09:49
@kritikmodi kritikmodi self-assigned this Jun 26, 2023
@kritikmodi kritikmodi added A-refunds Area: Refund flows C-bug Category: Bug labels Jun 26, 2023
@kritikmodi kritikmodi added this to the June 2023 Release milestone Jun 26, 2023
@dracarys18 dracarys18 changed the title fix(refunds): Modify refund fields to process updating of refund_reason fix(refunds): modify refund fields to process updating of refund_reason Jun 26, 2023
crates/api_models/src/refunds.rs Outdated Show resolved Hide resolved
@inventvenkat inventvenkat self-requested a review July 13, 2023 10:18
@bernard-eugine bernard-eugine added the P-high Priority: High label Jul 13, 2023
@inventvenkat inventvenkat added this pull request to the merge queue Jul 14, 2023
@kritikmodi kritikmodi disabled auto-merge July 14, 2023 07:33
@inventvenkat inventvenkat removed this pull request from the merge queue due to a manual request Jul 14, 2023
@inventvenkat inventvenkat added this pull request to the merge queue Jul 16, 2023
Merged via the queue into main with commit 9890570 Jul 16, 2023
10 of 17 checks passed
@inventvenkat inventvenkat deleted the fix_reason_field_update branch July 16, 2023 13:41
@SanchithHegde SanchithHegde removed the P-high Priority: High label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-refunds Area: Refund flows C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] "reason" field not being updated while hitting the Refunds - Update endpoint
6 participants