refactor(payments_start): remove redundant call to fetch payment method data #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-conventions-not-followed
SanchithHegde
changed the title
github-actions
bot
removed
the
S-conventions-not-followed
SanchithHegde
added
A-core
|
Thanks for the PR. Are you not able to install |
github-actions
bot
removed
the
S-conventions-not-followed
|
I finally managed to solve it with the help of my friend. Thank you |
There was a problem hiding this comment.
Other than that, looks good to me! Could you also please address the failing CI checks?
Thanks for the PR, @shreyash-Pandey-Katni!
SanchithHegde
approved these changes
Jun 30, 2023
Narayanbhat166
approved these changes
Jul 1, 2023
jarnura
approved these changes
Jul 3, 2023
jarnura
added
S-ready-for-merge
and removed
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This pull request removes the unnecessary call to fetch payment method data in the payments_start operation of the PaymentStart implementation. The payment method data fetch adds additional latency to the payments flow without being required in this particular flow.
Fixes #1327
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy