-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(payments_start): remove redundant call to fetch payment method data #1574
Conversation
Thanks for the PR. Are you not able to install |
I finally managed to solve it with the help of my friend. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that, looks good to me! Could you also please address the failing CI checks?
Thanks for the PR, @shreyash-Pandey-Katni!
Type of Change
Description
This pull request removes the unnecessary call to fetch payment method data in the payments_start operation of the PaymentStart implementation. The payment method data fetch adds additional latency to the payments flow without being required in this particular flow.
Fixes #1327
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy