feat(connector): [Bluesnap] Remove wallet call #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanchithHegde
previously approved these changes
Jul 7, 2023
ArjunKarthik
approved these changes
Jul 10, 2023
| @@ -504,84 +504,6 @@ impl api::PaymentSession for Bluesnap {} | |||
| impl ConnectorIntegration<api::Session, types::PaymentsSessionData, types::PaymentsResponseData> | |||
| for Bluesnap | |||
| { | |||
| fn get_headers( | |||
There was a problem hiding this comment.
@Sangamesh26 Do not remove this code, let it be and add comments. Revert only the core changes
| @@ -299,96 +286,6 @@ impl From<api_models::payments::ApplepayPaymentMethod> for ApplepayPaymentMethod | |||
| } | |||
| } | |||
|
|
|||
| impl TryFrom<&types::PaymentsSessionRouterData> for BluesnapCreateWalletToken { | |||
ArjunKarthik
requested changes
Jul 10, 2023
ArjunKarthik
added
the
S-waiting-on-author
|
@Sangamesh26 Please add necessary labels to the PR |
Sangamesh26
added
A-payment-methods
SanchithHegde
added
the
S-needs-conflict-resolution
Sangamesh26
added
S-waiting-on-review
ArjunKarthik
approved these changes
Jul 17, 2023
Narayanbhat166
approved these changes
Jul 18, 2023
ArjunKarthik
pushed a commit
that referenced
this pull request
Jul 19, 2023
Co-authored-by: Sahkal Poddar <sahkal.poddar@juspay.in> Co-authored-by: Pa1NarK <69745008+pixincreate@users.noreply.github.com>
Sangamesh26
added a commit
that referenced
this pull request
Jul 19, 2023
Co-authored-by: Sahkal Poddar <sahkal.poddar@juspay.in> Co-authored-by: Pa1NarK <69745008+pixincreate@users.noreply.github.com>
SanchithHegde
removed
P-high
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Remove Wallet call form bluesnap which was earlier treated a session call.
We get session object now from apple only instead of bluesnap.
Motivation and Context
Get session response from Apple pay instead of getting from connector
How did you test it?
Manual
Checklist
cargo +nightly fmt --allcargo clippy