Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(connector): [Adyen] Add UI test for Adyen Payment methods #1648

Merged
merged 20 commits into from
Jul 19, 2023
Merged

test(connector): [Adyen] Add UI test for Adyen Payment methods #1648

merged 20 commits into from
Jul 19, 2023

Conversation

swangi-kumari
Copy link
Contributor

@swangi-kumari swangi-kumari commented Jul 7, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added and fixed ui test for bank debits, bank redirects and wallets

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

adyen_ui_test

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jul 7, 2023
@swangi-kumari swangi-kumari requested a review from a team as a code owner July 7, 2023 10:49
@swangi-kumari swangi-kumari self-assigned this Jul 7, 2023
@swangi-kumari swangi-kumari requested review from a team, jarnura and ashokkjag as code owners July 7, 2023 11:13
@prasunna09 prasunna09 changed the title test(connector): [Adyen] Add UI test for Adyen Paymet methods test(connector): [Adyen] Add UI test for Adyen Payment methods Jul 12, 2023
srujanchikke
srujanchikke previously approved these changes Jul 14, 2023
View reviewed changes
jagan-jaya
jagan-jaya requested changes Jul 17, 2023
View reviewed changes
crates/router/tests/connectors/adyen_uk_ui.rs Outdated Show resolved Hide resolved
crates/router/tests/connectors/adyen_uk_ui.rs Outdated Show resolved Hide resolved
crates/router/tests/connectors/adyen_uk_ui.rs Show resolved Hide resolved
ArjunKarthik
ArjunKarthik requested changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@ArjunKarthik ArjunKarthik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the payment methods which have processing as their final status lets add comment

crates/router/tests/connectors/adyen_uk_ui.rs Outdated Show resolved Hide resolved
@ArjunKarthik ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jul 17, 2023
@ArjunKarthik ArjunKarthik added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jul 18, 2023
ArjunKarthik
ArjunKarthik previously approved these changes Jul 18, 2023
View reviewed changes
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Jul 19, 2023
Merged via the queue into main with commit 2e9b783 Jul 19, 2023
9 checks passed
@ArjunKarthik ArjunKarthik deleted the adyen-ui-test branch July 19, 2023 08:11
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagan-jaya jagan-jaya jagan-jaya approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@ashokkjag ashokkjag ashokkjag approved these changes

@srujanchikke srujanchikke srujanchikke approved these changes

@jarnura jarnura Awaiting requested review from jarnura

Assignees

@swangi-kumari swangi-kumari

Labels
A-connector-integration Area: Connector integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@swangi-kumari @jagan-jaya @ArjunKarthik @ashokkjag @srujanchikke @SanchithHegde