Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added CI test for code coverages #1700

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

feat: Added CI test for code coverages #1700

wants to merge 39 commits into from
+36 −1

Conversation

carrycooldude
Copy link

Reference to this issue: #1593

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@carrycooldude
Create code_coverage.yml
0c3f870 
Reference to this issue: juspay#1593
@carrycooldude carrycooldude requested a review from a team as a code owner July 13, 2023 08:31
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jul 13, 2023
@carrycooldude
Copy link
Author

carrycooldude commented Jul 13, 2023 •
edited

Reference to this issue #1593 #1622

@carrycooldude carrycooldude changed the title Create code_coverage.yml Added CI test for code coverages Jul 13, 2023
lsampras
lsampras reviewed Jul 13, 2023
View reviewed changes
.github/workflows/code_coverage.yml Outdated
Comment on lines 15 to 17
- name: Set up Rust
uses: actions/setup-rust@v1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use dtolnay/rust-toolchain@master for the rest of our actions,
Can we use that here as well...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, Let me update that

.github/workflows/code_coverage.yml Outdated
- name: Publish code coverage comment on PR
uses: mikepenz/action-github-comment@v2
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you need to grant the proper permissions at the start of the workflow.

Also can you add a https://app.codecov.io/gh integration here for CI checks,
(you can test this out on your forked repo since it's free to use)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you able to elobrate more about permission one again?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to this

will need to give write permissions on the PR so that it's able to add a comment

permissions: 
   pull-requests: write

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done this part

@bernard-eugine bernard-eugine added the P-high Priority: High label Jul 26, 2023
@carrycooldude carrycooldude changed the title Added CI test for code coverages refactor: Added CI test for code coverages Jul 28, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jul 28, 2023
@carrycooldude carrycooldude changed the title refactor: Added CI test for code coverages feat: Added CI test for code coverages Jul 28, 2023
@bernard-eugine bernard-eugine added this to the August 2023 Milestone milestone Aug 4, 2023
@carrycooldude
Copy link
Author

Any Updates @lsampras ?

@lsampras
Copy link
Member

Hey @carrycooldude ,

I tried running this branch on my fork (some minor changes needed),
here's the run.

Will look into this error,
Can merge once this is fixed...

In the meanwhile will keep the PR/issue open for discussing any suggestions/findings...

@bernard-eugine bernard-eugine added the ageing >2weeks Created > 2 weeks label Sep 1, 2023
@carrycooldude
Copy link
Author

carrycooldude commented Sep 12, 2023 •
edited

Screenshot from 2023-09-12 12-32-34

I don't know how to solve this...

Screenshot from 2023-09-12 12-46-05

@carrycooldude carrycooldude requested a review from a team as a code owner December 18, 2023 11:10
@aialok
Copy link

aialok commented Mar 26, 2024

Is this issue still available. I am ready to work on this. I already setup Codecov in one of the open source project.
Thank you : )

@SanchithHegde
Copy link
Member

@carrycooldude Are you still working on this, or do we close this PR?

If you are working on this, could you address the comment left by @lsampras here: #1700 (comment)?

@SanchithHegde SanchithHegde mentioned this pull request Mar 26, 2024
Open
@aialok
Copy link

aialok commented Mar 28, 2024

@SanchithHegde , can I work on this?
We have not heard back from @carrycooldude
If he is not working I am ready to work on this.

@carrycooldude
Copy link
Author

Hey @aialok , Yes I am still working on it and I implemented max. things and it just failing some test
Will do that , thanks for pinging here...

@likhinbopanna likhinbopanna modified the milestones: March 2024, April 2024 Apr 2, 2024
@bernard-eugine bernard-eugine modified the milestones: April 2024, May 2024 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsampras lsampras lsampras left review comments

@jarnura jarnura Awaiting requested review from jarnura

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

At least 2 approving reviews are required to merge this pull request.

Assignees

@lsampras lsampras

@carrycooldude carrycooldude

Labels
ageing >2weeks Created > 2 weeks P-high Priority: High
Projects
No open projects
hyperswitch - Public Roadmap
Status: Candidate
Milestone
May 2024 Release
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@carrycooldude @lsampras @aialok @SanchithHegde @bernard-eugine @likhinbopanna