refactor(pm_list): Update required fields for a payment method #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasunna09
added
A-connector-integration
ArjunKarthik
previously approved these changes
Jul 15, 2023
| field_type: enums::FieldType::UserCountry { | ||
| options: vec!["US".to_string(), "IN".to_string()], | ||
| field_type: enums::FieldType::UserAddressCountry { | ||
| options: vec![], |
There was a problem hiding this comment.
should be ALL or some country name right?
There was a problem hiding this comment.
Here, it is left empty because SDK will take care of countries list if not mentioned. (Discussed with SDK team)
Narayanbhat166
previously approved these changes
Jul 16, 2023
| @@ -1047,7 +1138,7 @@ impl Default for super::settings::RequiredFields { | |||
| ( | |||
| enums::Connector::Adyen, | |||
| vec
Chethan-rao
previously approved these changes
Jul 16, 2023
| RequiredFieldInfo { | ||
| required_field: "billing.address.line1".to_string(), | ||
| display_name: "line1".to_string(), | ||
| field_type: enums::FieldType::UserAddressline1, |
There was a problem hiding this comment.
We might have to consider renaming this and UserAddressline2 to UserAddressLine1 and UserAddressLine2 instead. This can be taken up in a separate PR.
There was a problem hiding this comment.
So this naming was given by sdk, so did the same, will ask them and modify them in next pr
prasunna09
dismissed stale reviews from Chethan-rao, Narayanbhat166, and ArjunKarthik
via
8d4176e
SanchithHegde
approved these changes
Jul 16, 2023
ArjunKarthik
approved these changes
Jul 16, 2023
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Refactored required fields for a payment method and removed fields not collected by sdk such as description, browser info.
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy