feat(compatibility): add support for stripe compatible webhooks #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhicodes-crypto
added
A-core
dracarys18
previously approved these changes
Jul 17, 2023
Narayanbhat166
changed the title
NishantJoshi00
approved these changes
Jul 17, 2023
inventvenkat
approved these changes
Jul 17, 2023
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add signing support for stripe compatibility layer. So when the merchant registers the stripe compatible webhook url he would get a stripe compatible webhook.
Additional Changes
Motivation and Context
How did you test it?
Registered stripe compatible webhook on stripe dashboard. Once router received the webhook from stripe it triggered another webhook to the same router , same merchant and the source got verified successfully. So outgoing and incoming stripe compatibility webhook is checked.
The webhook was received at stripe compatible endpoint webhook has been sent to merchant, but merchant wasn't able to handle it so error (because I did not provision for that)
On the merchant app, the webhook was received from hyperswitch and the source was verified which means the compatibility layer signed properly.
Checklist
cargo +nightly fmt --allcargo clippy