Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [Adyen] Implement Open Banking Uk in Bank Redirects #1802

Merged
merged 22 commits into from
Aug 8, 2023

Conversation

Sakilmostak
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables
    "payment_method": "bank_redirect",
    "payment_method_data": {
        "bank_redirect": {
            "open_banking_uk": {
                "issuer": "open_bank_success",
                "country": "GB"
            }
        }
    }

Motivation and Context

How did you test it?

Screen Shot 2023-07-27 at 12 57 43 PM
Screen Shot 2023-07-27 at 4 44 47 PM
Screen Shot 2023-07-27 at 4 46 02 PM
Screen Shot 2023-07-27 at 4 48 36 PM
Screen Shot 2023-07-27 at 4 49 08 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jul 27, 2023
@Sakilmostak Sakilmostak self-assigned this Jul 27, 2023
@Sakilmostak Sakilmostak requested review from a team as code owners July 27, 2023 11:27
srujanchikke
srujanchikke previously approved these changes Jul 28, 2023
@srujanchikke srujanchikke added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jul 28, 2023
@bernard-eugine bernard-eugine added this to the August 2023 Milestone milestone Aug 4, 2023
config/config.example.toml Outdated Show resolved Hide resolved
crates/router/src/connector/adyen/transformers.rs Outdated Show resolved Hide resolved
@ArjunKarthik ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Aug 8, 2023
@Sakilmostak Sakilmostak removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Aug 8, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Aug 8, 2023
Merged via the queue into main with commit b9f1270 Aug 8, 2023
12 checks passed
@ArjunKarthik ArjunKarthik deleted the adyen_openbanking branch August 8, 2023 11:52
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed labels Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants