Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Square] Add template code for connector Square #1834

Merged
merged 8 commits into from
Aug 3, 2023
Merged

feat(connector): [Square] Add template code for connector Square #1834

merged 8 commits into from
Aug 3, 2023

Conversation

deepanshu-iiitu
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add template code for new connector Square

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

For new connector Square integration

How did you test it?

Template code testing not required

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@deepanshu-iiitu deepanshu-iiitu requested review from a team as code owners August 1, 2023 07:52
@deepanshu-iiitu deepanshu-iiitu self-assigned this Aug 1, 2023
@deepanshu-iiitu deepanshu-iiitu added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 1, 2023
ArjunKarthik
ArjunKarthik requested changes Aug 1, 2023
View reviewed changes
crates/api_models/src/enums.rs Outdated Show resolved Hide resolved
crates/test_utils/src/connector_auth.rs Outdated Show resolved Hide resolved
@ArjunKarthik ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Aug 1, 2023
SamraatBansal
SamraatBansal requested changes Aug 2, 2023
View reviewed changes
crates/api_models/src/enums.rs Outdated Show resolved Hide resolved
crates/api_models/src/enums.rs Outdated Show resolved Hide resolved
crates/router/src/core/payments/flows.rs Outdated Show resolved Hide resolved
crates/router/tests/connectors/square.rs Outdated Show resolved Hide resolved
crates/router/src/types/api.rs Outdated Show resolved Hide resolved
ArjunKarthik
ArjunKarthik previously approved these changes Aug 2, 2023
View reviewed changes
SamraatBansal
SamraatBansal previously approved these changes Aug 2, 2023
View reviewed changes
@SamraatBansal SamraatBansal added S-ready-for-merge and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Aug 2, 2023
lsampras
lsampras previously approved these changes Aug 2, 2023
View reviewed changes
ashokkjag
ashokkjag previously approved these changes Aug 2, 2023
View reviewed changes
@deepanshu-iiitu deepanshu-iiitu dismissed stale reviews from ashokkjag and lsampras via 92169af August 3, 2023 07:05
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Aug 3, 2023
Merged via the queue into main with commit 80b74e0 Aug 3, 2023
10 of 16 checks passed
@ArjunKarthik ArjunKarthik deleted the add-connector-square-template branch August 3, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@ashokkjag ashokkjag ashokkjag approved these changes

@lsampras lsampras lsampras left review comments

@SamraatBansal SamraatBansal SamraatBansal left review comments

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

Assignees

@deepanshu-iiitu deepanshu-iiitu

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@deepanshu-iiitu @ArjunKarthik @lsampras @SamraatBansal @ashokkjag @SanchithHegde